Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share dialog should be quittable with 'esc' #1255

Closed
MariusAlbrecht opened this issue Dec 6, 2023 · 2 comments · Fixed by #1270
Closed

Share dialog should be quittable with 'esc' #1255

MariusAlbrecht opened this issue Dec 6, 2023 · 2 comments · Fixed by #1270
Assignees
Labels
enhancement New feature or request

Comments

@MariusAlbrecht
Copy link

Is your feature request related to a problem? Please describe.
only quittable by clicking the 'x' or outside of the popup. This makes mouse action neccesary and feels unnatural (for me. I basically click 'esc', realise it doesnt work and then use my mouse)

Describe the solution you'd like
also make 'esc' close the popup

@MariusAlbrecht MariusAlbrecht added the enhancement New feature or request label Dec 6, 2023
@barisgul15 barisgul15 self-assigned this Dec 13, 2023
@barisgul15 barisgul15 linked a pull request Dec 19, 2023 that will close this issue
@barisgul15
Copy link
Contributor

I just implemented this, because it also makes sense for me, but if you click outside anywhere on the tab on share dialog, it would also close the popup.

@MariusAlbrecht
Copy link
Author

I personally think that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants