-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1255 share dialog should be quittable with esc #1270
Conversation
Your Testserver will be ready at https://1270.test.live.mm.rbg.tum.de in a few minutes. Logins
|
Your code is working, but I think it doesn't solve the Issue mentioned in your PR. I think the Issue meant, that the share button at the bottom of a livestream, where you can share the current stream URL is not quittable with ESC. |
…x-init close on esc on watch.gohtml
Thanks for the feedback. When I saw popup, my mind immediately went to the chat but yeap, it was about something else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected
* popup chat close when esc pressed func. is added * redundant line deleted. * eslint fix * eslint-fix 2 * reversed the pop-up chat by deleting function close on esc and added x-init close on esc on watch.gohtml
Motivation and Context
Fixes the issue: #1255
Description
The eventlistener function to close the popup chat when esc is pressed is added to popup.ts and called in popup chat's html file.
Steps for Testing
Prerequisites:
Screenshots