Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1255 share dialog should be quittable with esc #1270

Merged
merged 5 commits into from
Dec 27, 2023

Conversation

barisgul15
Copy link
Contributor

Motivation and Context

Fixes the issue: #1255

Description

The eventlistener function to close the popup chat when esc is pressed is added to popup.ts and called in popup chat's html file.

Steps for Testing

Prerequisites:

  • 1 Lecturer
  1. Log in
  2. Create a course with chat enabled or navigate to a course for which chat is enabled.
  3. Open popup chat and press esc to quit the popup chat tab.

Screenshots

@barisgul15 barisgul15 linked an issue Dec 19, 2023 that may be closed by this pull request
Copy link

Your Testserver will be ready at https://1270.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@SebiWrn
Copy link
Collaborator

SebiWrn commented Dec 21, 2023

Your code is working, but I think it doesn't solve the Issue mentioned in your PR. I think the Issue meant, that the share button at the bottom of a livestream, where you can share the current stream URL is not quittable with ESC.

@barisgul15
Copy link
Contributor Author

Your code is working, but I think it doesn't solve the Issue mentioned in your PR. I think the Issue meant, that the share button at the bottom of a livestream, where you can share the current stream URL is not quittable with ESC.

Thanks for the feedback. When I saw popup, my mind immediately went to the chat but yeap, it was about something else.

Copy link
Collaborator

@SebiWrn SebiWrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@SebiWrn SebiWrn merged commit 27c8945 into dev Dec 27, 2023
8 checks passed
@SebiWrn SebiWrn deleted the 1255-share-dialog-should-be-quittable-with-esc branch December 27, 2023 15:41
SebiWrn pushed a commit that referenced this pull request May 7, 2024
* popup chat close when esc pressed func. is added

* redundant line deleted.

* eslint fix

* eslint-fix 2

* reversed the pop-up chat by deleting function close on esc and added x-init close on esc on watch.gohtml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share dialog should be quittable with 'esc'
2 participants