playlist scroll pos #1120
Merged
playlist scroll pos #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1120.test.live.mm.rbg.tum.de in a few minutes. Logins
|
|
What's the status of this? @mono424 |
Its ready to get reviewed :) |
mono424
requested review from
MatthiasReumann,
alexanderstephan and
joschahenningsen
joschahenningsen
approved these changes
Sep 21, 2023
Mjaethers
pushed a commit
to Mjaethers/gocast
that referenced
this pull request
Nov 3, 2023
* first test * clearner code * lint fi
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* first test * clearner code * lint fi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
If the playlist sidebar is not visible on page start, the scroll position is not set to the active item.
Bildschirmaufnahme.2023-09-21.um.12.06.14.mov
Description
This pr adds a observer that scrolls to the right position upon sidebar open.
Steps for Testing
Prerequisites:
Screenshots
Bildschirmaufnahme.2023-09-21.um.12.05.51.mov