Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align buttons on watch page and user context dropdown on homepage #1240

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

YiranDuan721
Copy link
Contributor

@YiranDuan721 YiranDuan721 commented Nov 19, 2023

closes #1235

Screenshots

Change 1:

Alignment of "Select Theme" button on the watch page
Before: Before After: After

Change 2:

Alignment of elements in "User Context" on the home page

Before: Before After: After

Copy link

Your Testserver will be ready at https://1240.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

Copy link
Collaborator

@alexanderstephan alexanderstephan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now, thanks! 😊

@alexanderstephan alexanderstephan merged commit d29a949 into dev Nov 20, 2023
9 checks passed
@alexanderstephan alexanderstephan deleted the 1235_misaligned_icons_on_watch_page branch November 20, 2023 16:49
SebiWrn pushed a commit that referenced this pull request May 7, 2024
)

- Alignment of "Select Theme" button on the watch page
- Alignment of elements in "User Context" on the home page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Select Theme" or "Toggle Menu" misaligned
2 participants