player control: 'next' button #1268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexanderstephan could you please approve the ci workflows? Thanks :) |
|
@PSandro done :) If you plan to do more work on TUM-Live, we can add you as a project member. Make sure to merge the latest master to get the updated linter settings. |
|
@PSandro Do you still want to merge this PR? If so please fix the ci errors so we can check and approve your PR |
|
Hi, I currently don't have the time capacity to continue working on this. Will reopen when that changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change aims to provide a quick way of navigating to the next video in queue. Currently this is possible via the playlist functionality. But opening the playlist view and clicking on the 'next' button there requires some mouse pointer movement an more than 1 click :)
The alternative would be to have a 'skip'/'next' button right next to the pause/play button in the player control bar of the videoplayer. This PR tries to implement exactly that.
fixes #1170
Description
Changes made only affect the
webpart of gocast. TheDataStoreandStreamPlaylistEntryis added to the Video.js setup code inTUMLiveVjs.ts. The streamID of the current stream is used to - if exists - fetch the stream's playlist and get the next video in line which then gets linked to via the 'next' button.Steps for Testing
As I could not test the changes locally myself, testing would rely on the test deployment through CI. One would need to open a stream and confirm that the 'next' button is indeed shown and links to the next video in the playlist. Therefor one could use the existing playlist navigation in the playlist view, then go back and try the same thing using the newly added 'next' button in the player control bar.
Screenshots
Since I could not test the setup locally, there are no screenshots yet. I will updated them as soon as possible.
This is a draft for now since probably more development is needed.