Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one streaming key for each course #1323

Closed

Conversation

Mjaethers
Copy link
Contributor

Motivation and Context

Closes #124
Currently, every time a lecturer starts a new self-stream, they have to go into their streaming software and change the stream server and key. This is a bit cumbersome as most lecturers only need to stream to one course, and therefore the credentials should be course-specific, instead of stream-specific.

Description

Each course now has it's own stream key, which is generated when the course is created. Every time a new stream is created, it's stream key will default to the course stream key.

The stream key of a course can be regenerated in the course -> settings tab. This might be used if the stream key is leaked, or to re-sync all the stream keys should they have been changed individually.

The stream key of a stream can be regenerated in the Edit Lecture tab on the course page, this might be used for hosting concurrent streams of a course. Here the stream key can also be restored to the course stream key.

Since the worker can no longer identify streams by their key, it now identifies a stream by key and time. This will cause problems if stream times overlap within 30 minutes.

Steps for Testing

Prerequisites:

  • 1 Lecturer
  • 1 Self-Stream setup
  1. Log in
  2. Navigate to a course or create a new one
  3. Create some Live-streams, notice they will all have the same key
  4. Press Edit Lecture -> Regenerate Key of a Stream, notice it will no longer use the same key as the other streams in that course
  5. Navigate to the course settings tab and press Regenerate course wide stream keys, notice that all the stream keys will change and will once again all be the same
  6. Regenerate Key of a Stream again
  7. Press Edit Lecture -> Restore Key, notice it will once again use the same key as the other streams in that course

Screenshots

Screenshot 2023-11-29 at 16-49-51 TUM-Live Administration
Changing the key of a specific stream

Screenshot 2023-11-20 at 13-47-00 MUT-Live Administration
Changing the key of all stream in course

@Mjaethers Mjaethers changed the title 124 require only one streaming key clean require only one streaming key Jan 31, 2024
@Mjaethers Mjaethers changed the title require only one streaming key Only one streaming key for each course Jan 31, 2024
@Mjaethers Mjaethers marked this pull request as draft January 31, 2024 12:05
@Mjaethers Mjaethers force-pushed the 124-require-only-one-streaming-key-clean branch from c096cdd to 204525c Compare January 31, 2024 12:22
@Mjaethers Mjaethers marked this pull request as ready for review January 31, 2024 12:23
@Mjaethers
Copy link
Contributor Author

This PR is the same as #1242 but with a cleaned up git history

@SebiWrn
Copy link
Collaborator

SebiWrn commented Sep 23, 2024

@Mjaethers Do you still want to merge this PR? If so please fix the pipeline errors so we can check and approve your PR.

@SebiWrn
Copy link
Collaborator

SebiWrn commented Sep 23, 2024

Although I think we don't really need this feature anymore as @carlobortolan already implemented a first version of a proxy for the rtsp streams and also implemented a new streaming key system with that

@SebiWrn SebiWrn closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require only one streaming key for each course
3 participants