Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed recent vods/streams course links not working #1384

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

karjo24
Copy link
Contributor

@karjo24 karjo24 commented Oct 16, 2024

Motivation and Context

Currently, when the start page is in a new semester and streams or vods of the last semester show up as recent stream/vod, the attached course link does not work and just redirects to the start page again.

Description

It passes the year and the semester to the existing function that handles changing to the course page so that it knows, which semester the course is in. Currently, the function just gets the course slug and assumes that the course is in the current semester.

Steps for Testing

Prerequisites:

  • 1 User
  • 1 vod/stream of a course that is in a more recent semester than any other course.
  • 1 vod/stream of a course that is in an older semester
  1. Navigate to the homepage.
  2. See both vods/streams show up in "Recent Vods/Streams"
  3. Click on the links referring to the respective courses
  4. Admire the respective course pages, regardless of the semester of the course

Copy link

Your Testserver will be ready at https://1384.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@karjo24 karjo24 requested a review from SebiWrn October 16, 2024 16:40
@SebiWrn SebiWrn merged commit 987b174 into dev Oct 17, 2024
9 checks passed
@SebiWrn SebiWrn deleted the recent-vods-fix branch October 17, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants