Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/rtmp proxy #1387

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Enh/rtmp proxy #1387

merged 6 commits into from
Oct 21, 2024

Conversation

carlobortolan
Copy link
Member

Motivation and Context

See #1386.

Description

  • Updated token panel that allows lecturers to create new lecturer tokens with additional info for different streaming software/services.
  • New API endpoint at /api/token/proxy that can be used by the RTMP Proxy to exchange the lecturer token with a stream-specific URL for an upcoming stream.
  • Added test courses that are automatically created under the "TEST COURSES" semester when one starts streaming without having scheduled active or soon starting stream.

Steps for Testing

Prerequisites:

  1. Log in.
  2. Create a soon-starting stream.
  3. Go to the token panel and create a new lecturer token.
  4. Follow the instructions on the screen to start self-streaming from OBS via the RTMP-Proxy, or make a manual POST request to http://localhost:8081/api/token/proxy/<your-token> to check if the stream URL is correct.

Note

To change the default settings of the test courses, see:

func (d streamsDao) CreateOrGetTestStreamAndCourse(user *model.User) (model.Stream, model.Course, error) {

Screenshots

image
image
image
image

@carlobortolan carlobortolan added enhancement New feature or request go Pull requests that update Go code priority:low UI awaiting feedback labels Oct 18, 2024
@carlobortolan carlobortolan requested a review from SebiWrn October 18, 2024 10:25
@carlobortolan carlobortolan self-assigned this Oct 18, 2024
Copy link

Your Testserver will be ready at https://1387.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@carlobortolan carlobortolan linked an issue Oct 18, 2024 that may be closed by this pull request
@carlobortolan carlobortolan marked this pull request as ready for review October 21, 2024 11:00
@carlobortolan carlobortolan marked this pull request as draft October 21, 2024 11:01
@carlobortolan carlobortolan marked this pull request as ready for review October 21, 2024 11:04
@carlobortolan carlobortolan merged commit 8b3a059 into dev Oct 21, 2024
8 checks passed
@carlobortolan carlobortolan deleted the enh/rtmp_proxy branch October 21, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code Open Source Lab priority:low UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unique RTMP-URL for self-streams
2 participants