Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1291 split view progress bar in wrong position after entering fullscreen mode if the width ratio of two views adjusted #1393

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

karjo24
Copy link
Contributor

@karjo24 karjo24 commented Oct 24, 2024

Motivation and Context

See Issue #1291.

Description

Adjusting size of players in splitview when in fullscreen mode (or vice versa) doesn't result in the control bar being in the wrong position anymore. This applies to subtitles as well.
Currently, the control bar of the right video player is used as the control bar for both video players, the one on the left is hidden. This results in said weird issues as the control bar has to have (potentially high) negative left margins. As I couldn't figure out what exactly is the issue with updating the left margin, this is fixed by switching roles of the two control bars (left is "global" control bar, right is hidden). This may have side effects! Only side effect known to me is that the subtitle settings menu is now an overlay of the left video player (instead of the right player).

Steps for Testing

Prerequisites:

  • 1 Livestream / VOD (preferably with subtitles)
  1. Navigate to a Livestream
  2. Play around by adjusting sizes and toggling fullscreen mode.
  3. See no errors.

Copy link

Your Testserver will be ready at https://1393.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@karjo24
Copy link
Contributor Author

karjo24 commented Oct 24, 2024

This may have side effects! Only side effect known to me is that the subtitle settings menu is now an overlay of the left video player (instead of the right player).

This one and only side effect is irrelevant imo and as far as I can tell, but I my have missed something. I'd guess, that there was a reason for choosing the non-straight-forward solution of making the right control bar the main control bar, but I haven't found anything plausible yet. This may be on me though. If anyone knows more, let me know.

@karjo24 karjo24 requested a review from a team November 29, 2024 10:07
Copy link
Member

@carlobortolan carlobortolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants