Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1172 lecture week view #1411

Merged
merged 8 commits into from
Dec 5, 2024
Merged

1172 lecture week view #1411

merged 8 commits into from
Dec 5, 2024

Conversation

karjo24
Copy link
Contributor

@karjo24 karjo24 commented Nov 21, 2024

Motivation and Context

See #1172.

Description

Introduces a new button to toggle to Week View. Computes the week count as the number of weeks that have passed since the first lecture (+1 so that it starts at 1). Ignores weeks without any lecture (e.g. Christmas Break).

Steps for Testing

Prerequisites:

  • 1 Course
  • 1 User
  1. Navigate to course page
  2. Click on Week View
  3. Make sure that behavior doesn't change when using any of the other buttons in any order.

Screenshots

Screenshot from 2024-11-21 09-40-29

@karjo24 karjo24 self-assigned this Nov 21, 2024
@karjo24 karjo24 linked an issue Nov 21, 2024 that may be closed by this pull request
Copy link

Your Testserver will be ready at https://1411.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@karjo24
Copy link
Contributor Author

karjo24 commented Nov 21, 2024

Everything is working as intended. However, I'm not too happy with how this is implemented. I couldn't make it work easily in any other way I tried. Maybe someone else has a better idea?

@karjo24 karjo24 requested a review from a team November 29, 2024 09:11
@karjo24 karjo24 marked this pull request as ready for review November 29, 2024 09:24
Copy link
Member

@carlobortolan carlobortolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
Only suggestion would be to update the mobile view so that the buttons have a better layout (see screenshot).

Screen Shot 2024-11-29 at 11 34 29

Copy link
Member

@carlobortolan carlobortolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
image

@karjo24 karjo24 merged commit 1a5939d into dev Dec 5, 2024
8 checks passed
@karjo24 karjo24 deleted the 1172-lecture-week-view branch December 5, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lecture Week view
2 participants