-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
サヨナラ発動時にバフエフェクトを付与 #714
Merged
Merged
サヨナラ発動時にバフエフェクトを付与 #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UnusualSkyBlock into fix/tutrial-click-event
Closed
NePonpon
reviewed
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
付与するまでの処理はokです
NePonpon
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケットURL
GH-683
対応内容・対応背景・妥協点
サヨナラがあまりにも弱すぎたため。
やったこと
サヨナラ→レイズが発動した場合、攻撃力上昇10を30秒と耐性5を5秒付与する。
やってないこと
演出の変更・スキル説明文の変更
補足
検知用のタグはSayonaraを使用しています。
チェックリスト (ガイドライン)
Pull Request
Commit
[Add|Delete|Modify|Fix|Refactor|Move]
等の動詞の原形を追加してください。
(参考)
(参考 2)
GH-〇〇
でチケット番号をつけてください(チケットが存在しない場合は
NO-ISSUE
にしてください)Branch
feature/[簡単な説明]
またはfix/[簡単な説明]
であるべきです