Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing step in legacy installation #5253

Closed

Conversation

brotkrueml
Copy link
Contributor

Before changing to a "public" directory, that directory must be created.

Before changing to a "public" directory, that directory must be created.
@linawolf
Copy link
Member

I think in this example public is just the directory where the webroot is pointing. So it usually already exists.

@brotkrueml
Copy link
Contributor Author

I think in this example public is just the directory where the webroot is pointing. So it usually already exists.

It is about a new installation. I done that in a new folder, downloaded the zip, extracted it, no public available. And now?

@garvinhicking
Copy link
Contributor

You are right, the current example is not complete.

However, in "normal" hosting environments one probably already has a documentroot setup for them. So IMO we could revise this example maybe to say someting like:

# If a VirtualHost has been setup already with a mapped DocumentRoot,
# change to that directory. This is usually called "public", "htdocs", "html" or similar.
# Create a directory, if none exist yet, and later map that directory to be your DocumentRoot

just an example, I'm not terribly fond of it. What do you think about something like this? @brotkrueml ?

@brotkrueml
Copy link
Contributor Author

Fine for me.

@brotkrueml brotkrueml closed this Feb 4, 2025
@brotkrueml brotkrueml deleted the mkdir-legacyinstall branch February 4, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants