Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

[TASK] Improve details of overriding TCEFORM field config #448

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

garvinhicking
Copy link
Contributor

@garvinhicking garvinhicking commented Apr 10, 2024

I had a discussion with @lolli42 about this override of TCEFORM.

Background is this core patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83646
Also I pressured kindly asked @sbuerk about reproducing this and he confirmed trouble with this; effort is ongoing to see how to solve this (thanks!!).

The previously documented change of a TCEFORM like this (multiple variations so this Page TSConfig can be inserted into any TYPO3 from v8 to v13):

TCEFORM.tt_content.pi_flexform.login.sDEF.showForgotPassword.label = TESTLABEL
TCEFORM.tt_content.pi_flexform.login.sDEF.showForgotPassword.config.readOnly = true
TCEFORM.tt_content.pi_flexform.login.sDEF.settings\.showForgotPassword.label = TESTLABEL
TCEFORM.tt_content.pi_flexform.login.sDEF.settings\.showForgotPassword.config.readOnly = true
TCEFORM.tt_content.pi_flexform.felogin_login.sDEF.showForgotPassword.label = TESTLABEL
TCEFORM.tt_content.pi_flexform.felogin_login.sDEF.showForgotPassword.config.readOnly = true
TCEFORM.tt_content.pi_flexform.felogin_login.sDEF.settings\.showForgotPassword.label = TESTLABEL
TCEFORM.tt_content.pi_flexform.felogin_login.sDEF.settings\.showForgotPassword.config.readOnly = true

actually DOES NOT WORK in any TYPO3 Version between 8 to 13. The label is adjusted, but a config setting is NOT applied.

The core code reads like this has never been possible and should have never made it into the documentation. A "todo" note with the previous doc is left with a todo comment.

Additionally the documentation needs to specify in depth, why only certain attributes of the config (of normal fields) can be changed, and especially why changing a field to contain the RTE is not possible (as this comes up every now and then).

Releases: main, 12.4, 11.5

@garvinhicking garvinhicking merged commit 1e81036 into main Apr 11, 2024
4 checks passed
@garvinhicking garvinhicking deleted the fix-tceform branch April 11, 2024 08:03
Copy link
Contributor

The backport to 11.5 failed:

The process '/usr/bin/git' failed with exit code 1
stderr
error: could not apply 330f75a... [TASK] Improve details of overriding TCEFORM field config
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

stdout
Auto-merging Documentation/PageTsconfig/TceForm.rst
CONFLICT (content): Merge conflict in Documentation/PageTsconfig/TceForm.rst

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-11.5 11.5
# Navigate to the new working tree
cd .worktrees/backport-11.5
# Create a new branch
git switch --create backport-448-to-11.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 330f75a33fcfc0a82d9eee4835703f20d4c4bb5e,21b9004b42471832249a25d4246be46a8da2980e
# Push it to GitHub
git push --set-upstream origin backport-448-to-11.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-11.5

Then, create a pull request where the base branch is 11.5 and the compare/head branch is backport-448-to-11.5.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants