[TASK] Add missing page.meta attribute sub-property

[brotkrueml]

The more generic attribute sub-property can be used to set the attribute to any arbitrary value. An example is already available for the Open Graph meta tags. Therefore, it is more generic than the httpEquivalent sub-property.

Releases: main, 12.4

[brotkrueml]

Waiting for #1336 to be merged as it may conflict with this one.

[linawolf]

Where do you have the information from? Source?

[brotkrueml]

Real world.

Look at the examples at the end of the page, there attribute is used.

It took me quite some time to get og:image:width working (it only works with attribute = property given - without it, an error occurs).

[brotkrueml]

@linawolf Can we proceed here?

[linawolf]

I am not blocking this, but someone who knows more about it would have to review

[brotkrueml]

As there is no interest in this PR, closing it.

[garvinhicking]

I nust stumbled across this. Would you like to reopen? I'd review :-)

[github-actions]

The backport to 12.4 failed:

The process '/usr/bin/git' failed with exit code 128

stderr

error: commit 98846b2441949beb69082cba94c1ff12d02c61d9 is a merge but no -m option was given.
fatal: cherry-pick failed

stdout

Auto-merging Documentation/TopLevelObjects/Page/Index.rst
[backport-1337-to-12.4 0ea9c107] [TASK] Add missing page.meta attribute sub-property
 Author: Chris Müller <[email protected]>
 Date: Sat Sep 21 20:48:46 2024 +0200
 1 file changed, 5 insertions(+)

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-12.4 12.4
# Navigate to the new working tree
cd .worktrees/backport-12.4
# Create a new branch
git switch --create backport-1337-to-12.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ea3a0ba3b0c453d7a62320205727f72915b8e714,98846b2441949beb69082cba94c1ff12d02c61d9,7a6fb936b359497214fc1fd4dafbfcc3e94b7c65
# Push it to GitHub
git push --set-upstream origin backport-1337-to-12.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-12.4

Then, create a pull request where the base branch is 12.4 and the compare/head branch is backport-1337-to-12.4.

[github-actions]

The backport to 13.4 failed:

The process '/usr/bin/git' failed with exit code 128

stderr

error: commit 98846b2441949beb69082cba94c1ff12d02c61d9 is a merge but no -m option was given.
fatal: cherry-pick failed

stdout

Auto-merging Documentation/TopLevelObjects/Page/Index.rst
[backport-1337-to-13.4 788fa8c1] [TASK] Add missing page.meta attribute sub-property
 Author: Chris Müller <[email protected]>
 Date: Sat Sep 21 20:48:46 2024 +0200
 1 file changed, 5 insertions(+)

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-13.4 13.4
# Navigate to the new working tree
cd .worktrees/backport-13.4
# Create a new branch
git switch --create backport-1337-to-13.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ea3a0ba3b0c453d7a62320205727f72915b8e714,98846b2441949beb69082cba94c1ff12d02c61d9,7a6fb936b359497214fc1fd4dafbfcc3e94b7c65
# Push it to GitHub
git push --set-upstream origin backport-1337-to-13.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-13.4

Then, create a pull request where the base branch is 13.4 and the compare/head branch is backport-1337-to-13.4.

[garvinhicking]

Probably not going to backport this manually.

[linawolf]

Manually backported