Allow extending Symfony DI in surf #800
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the feature to use the symfony DI in custom surf extensions.
I was not able to use the logger in my custom Task. So I decided to make surf extendable.
Just create a Extension which extends
TYPO3\Surf\Cli\Symfony\DependencyInjection\Extensioncreate a composer package with the
"type": "typo3-surf-exstension"and define the extension namespace atextra.typo3-surf.extension.What is the current behavior? (You can also link to an open issue here)
I cant use for example the logger in my custom task.
What is the new behavior (if this is a feature change)?
The Symfony DI can get used, for example, in custom tasks.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: