refactor: distributed metadata #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecdwm
force-pushed
the
refactor/distributed-metadata
branch
from
d51e1c1 to
5d43463
Compare
alecdwm
force-pushed
the
refactor/distributed-metadata
branch
from
4870892 to
982cbee
Compare
* wip: chaindata logos & ignore non default chains * feat: disable networks * chore: cleanup * feat: enable/disable tokens * feat: search & enable known evm networks * fix: perf when updating networks & tokens * chore: cleanup * fix: balances subscription init performance * fix: larger toggle click zone * fix: reset evm network * fix: virtualized rows * fix: filter behavior * fix: token filter * feat: clear button on search input * feat: token form adjustments * feat: enable toggle on chains forms * fix: wording
alecdwm
force-pushed
the
refactor/distributed-metadata
branch
3 times, most recently
from
b2a5210 to
2052ef5
Compare
alecdwm
force-pushed
the
refactor/distributed-metadata
branch
from
2052ef5 to
4f8523d
Compare
chidg
reviewed
Dec 13, 2023
| )} | ||
| {hasAccounts && <FullscreenPortfolioAssets balances={balancesToDisplay} />} | ||
| <div className="text-body-secondary mt-72 flex flex-col items-center justify-center gap-8 text-center"> | ||
| <div>{t("Enable some networks to display your assets")}</div> |
There was a problem hiding this comment.
When there is a selected account active, this message doesn't quite make sense. In that case we should say "No networks are enabled for this account. Enable some {{ Polkadot || Ethereum }} networks to display your assets."
| @@ -7,27 +9,35 @@ import { | |||
| import { useMemo } from "react" | |||
| import { useRecoilValue } from "recoil" | |||
|
|
|||
| export const useChains = (withTestnets: boolean) => { | |||
| // // keep db data ption("chains") | |||
| type ChainsFilter = "all" | "enabledWithTestnets" | "enabledWithoutTestnets" | |||
There was a problem hiding this comment.
Prefer to use Enums or constants for values like this
Although, since we now have two states (all/enabled and testnets on/off) perhaps an options object would be more suitable?
There was a problem hiding this comment.
done in asset discovery pr
* feat: merge main atoms into one * feat: merge atoms * fix: tests
|
Marking this a draft until we merge assets discovery back into it |
* fix: responsive account name alignment in portfolio account picker (#1183) * fix: responsive account name alignment in portfolio account picker * fix: don't break text-ellipsis * fix: allow blockeplorer to be null in wallet_addEthereumChain (#1175) * wip: asset discovery * refactor: optimize scan * feat: token rates for asset discovery * feat: scan contextual menu * fix: prevent bug in analytics (#1186) * fix: remove nonce when estimating gas to validate txs (#1189) * feat: revoke approval signing ui (#1190) * fix: layout shift on dashboard asset rows (#1192) * fix: wording * Upgrade Ledger deps (#1193) * chore: upgrade ethereum ledger dependencies * fix: improve Ledger connection error messages * chore: specify version of ledger/hw-transport library * chore: version bump 1.20.1 (#1194) * chore: rename enabled to active * fix: tests * chore: cleanup * fix: enable => activate * fix: log timer warnings * feat: options param on main hooks * feat: scan native tokens * feat: scan & activate native tokens * fix: testnets management * fix: prevent auto switch to disabled network * feat: enrich when adding network from dapp * feat: migrate to new evm default networks * feat: privacy notice * fix: typo * feat: launch scan after adding account * feat: add border to notification container * feat: alerts if new tokens detected * chore: self review * chore: remove comment * fix: persist tokens count * fix: incorrect instantiation of `ChainConnectorEvm` (#1199) * fix: incorrect instantiation of `ChainConnectorEvm` * fix: combine ChaindataEvmNetworkProvider and ChaindataTokenProvider in ChainConnectorEvm --------- Co-authored-by: alecdwm <[email protected]> * fix: connected includes removed addreses (#1205) * fix: invoke stopListening when an error is caught (#1203) * feat: rework tokens page * fix: poll crowdloan contributions (fixes #1152) * feat: token info context menu * fix: erc20 check --------- Co-authored-by: Alec WM <[email protected]> Co-authored-by: Chid Gilovitz <[email protected]> Co-authored-by: Tiến Nguyễn Khắc <[email protected]> Co-authored-by: Chris Ling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scoped @ #1076