feat: add account redesign #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset(s) detectedThis PR includes changeset(s) for the following changed packages: Not sure what this means? Click here to learn what changesets are. |
alecdwm
force-pushed
the
feat/add-account-redesign
branch
from
386cf36 to
d90029b
Compare
alecdwm
force-pushed
the
feat/add-account-redesign
branch
from
7f34531 to
41f6bf7
Compare
alecdwm
force-pushed
the
feat/add-account-redesign
branch
from
6a0ef04 to
4d47344
Compare
alecdwm
force-pushed
the
feat/add-account-redesign
branch
from
869b90b to
a08ae85
Compare
alecdwm
force-pushed
the
feat/add-account-redesign
branch
from
a08ae85 to
402f7b5
Compare
UrbanWill
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
LGMT,
However there is this weird yo-yo effect when scrolling the virtualized dropdown networks list too fast. I tried to fix it myself but seems like react-virtual lib is not playing nice with headlessUi components. Time to give shadcn a go?
Don't think it is a blocker though, since the list is quite big and users will make use of the search functionality.
In the following video I never scrolled up:
Screen.Recording.2024-12-24.at.12.14.00.mov
alecdwm
pushed a commit
that referenced
this pull request
Dec 29, 2024
alecdwm
added a commit
that referenced
this pull request
Dec 29, 2024
* feat: add account redesign * fix: deselect AccountTypeNetworkSearch on click * fix: optional AccountCreateMethodButton.networks prop * fix: include nativetoken symbol in network search * fix: copy feedback * fix: also disable account type picker on second add/watch account page * fix: navigate to correct tab when clicking on `Add Account` breadcrumb * fix: copy feedback * feat: add back button * fix: watched account form spacing * fix: trim account type network search input * fix: account type search field font size
chidg
added a commit
that referenced
this pull request
Dec 30, 2024
* feat: add account redesign (#1760) * feat: add account redesign * fix: deselect AccountTypeNetworkSearch on click * fix: optional AccountCreateMethodButton.networks prop * fix: include nativetoken symbol in network search * fix: copy feedback * fix: also disable account type picker on second add/watch account page * fix: navigate to correct tab when clicking on `Add Account` breadcrumb * fix: copy feedback * feat: add back button * fix: watched account form spacing * fix: trim account type network search input * fix: account type search field font size * fix: weird scroll behaviour in AccountTypeNetworkSearch * fix: comboboxOptions max height * fix: app crashing when no option selected, handle side effects in handleChange fn * revert: max height to fixed height * fix: disable spellcheck on network search combobox * chore: show active networks first in add account network dropdown * chore: remove account type selection buttons from some account creation screens --------- Co-authored-by: Will Urban <[email protected]> Co-authored-by: Chid Gilovitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements new designs for
/accounts/add, including a network picker for users who don't know whether they need to create an Ethereum or a Polkadot account for use with a given chain.