fix: weird scroll behaviour in AccountTypeNetworkSearch #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add account redesign * fix: deselect AccountTypeNetworkSearch on click * fix: optional AccountCreateMethodButton.networks prop * fix: include nativetoken symbol in network search * fix: copy feedback * fix: also disable account type picker on second add/watch account page * fix: navigate to correct tab when clicking on `Add Account` breadcrumb * fix: copy feedback * feat: add back button * fix: watched account form spacing * fix: trim account type network search input * fix: account type search field font size
alecdwm
force-pushed
the
fix/weird-scrolling
branch
from
81f7fe7 to
c478796
Compare
UrbanWill
previously approved these changes
Dec 30, 2024
There was a problem hiding this comment.
LGTM! 🔥
Pushed to minor fixes:
1- Dropdown had a fixed size, when the search result has fewer options the dropdown should be smaller.
Screen shot before the fix:
2- Searching and then hitting enter caused the app to crash because an empty option is still a default combo box option. Created a handleChange fn for that case, and tidied up side effects inside this fn as well.
Example before the fix:
Screen.Recording.2024-12-30.at.10.37.35.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally used
@tanstack/react-virtualinstead of the built-in virtual prop of<Combobox />because I needed theNetwork | Account Typeheader inside of the dropdown list.This PR implements an alternative solution; it uses the built-in virtual prop instead of
@tanstack/react-virtual, and then implements the header as a faux<ComboboxOption />.As far as I can tell this fixes the weird scrolling behaviour.