Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial FieldAPI tests, made FieldAPI typings much more strict #405

Merged
merged 13 commits into from
Aug 28, 2023
Merged

Initial FieldAPI tests, made FieldAPI typings much more strict #405

merged 13 commits into from
Aug 28, 2023

Conversation

crutchcorn
Copy link
Member

@crutchcorn crutchcorn commented Aug 28, 2023

This PR:

  • Fixes typing issues with insertValue
  • Makes types more strict for FieldAPI based on the name field input (If no explicit TData is passed)
  • Adds initial tests for FieldAPI
  • Updates TypeScript version to avoid a bug where TS couldn't find this
  • Updates TypeScript ESlint to support the new version of TypeScript
  • Updates ESlint and prettier plugins to fix issues on my local machine
  • Temporarily removes React 17 check from CI

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@25237e4). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage        ?   59.35%           
=======================================
  Files           ?        7           
  Lines           ?      374           
  Branches        ?       91           
=======================================
  Hits            ?      222           
  Misses          ?      120           
  Partials        ?       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tannerlinsley tannerlinsley merged commit 7ee5524 into TanStack:main Aug 28, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants