Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make validateAllFields more stable #526

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Conversation

crutchcorn
Copy link
Member

This PR closes #521 by making validateSync better at actually returning when it should trigger validateAsync internally. This makes our validation logic substantially more stable

Copy link

codesandbox-ci bot commented Dec 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (c2f9957) to head (091cfb8).
Report is 472 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #526      +/-   ##
==========================================
+ Coverage   84.55%   91.64%   +7.08%     
==========================================
  Files           9       21      +12     
  Lines         395      670     +275     
  Branches      109      185      +76     
==========================================
+ Hits          334      614     +280     
+ Misses         52       49       -3     
+ Partials        9        7       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn crutchcorn merged commit e6e3322 into main Dec 3, 2023
@crutchcorn crutchcorn deleted the validateAllFields-stable branch December 3, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validateAllFields isn't working with touched fields
2 participants