feat(eslint-plugin): no void queryFn #8925

Newbie012 · 2025-04-01T14:12:17Z

read discussion first - #8927

…ery-fn-2

nx-cloud · 2025-04-01T14:19:56Z

View your CI Pipeline Execution ↗ for commit 9ee8ded.

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 44s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	4s	View ↗

☁️ Nx Cloud last updated this comment at 2025-04-07 08:48:26 UTC

pkg-pr-new · 2025-04-01T14:21:25Z

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8925

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8925

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8925

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8925

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8925

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8925

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8925

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8925

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8925

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8925

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8925

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8925

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8925

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8925

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8925

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8925

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8925

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8925

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8925

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8925

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8925

commit: 9ee8ded

github-actions · 2025-04-01T14:21:26Z

Sizes for commit 9ee8ded:

Branch	Bundle Size
Main
This PR

…nto feat-no-void-query-fn-2

…ery-fn-2

codecov · 2025-04-07T08:49:11Z

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.30%. Comparing base (644e945) to head (9ee8ded).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8925      +/-   ##
==========================================
+ Coverage   44.09%   44.30%   +0.20%     
==========================================
  Files         201      202       +1     
  Lines        8025     8058      +33     
  Branches     1767     1776       +9     
==========================================
+ Hits         3539     3570      +31     
- Misses       4058     4060       +2     
  Partials      428      428

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`88.08% <ø> (ø)`
@tanstack/eslint-plugin-query	`88.19% <93.93%> (+0.37%)`	⬆️
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`0.00% <ø> (ø)`
@tanstack/query-core	`94.77% <ø> (ø)`
@tanstack/query-devtools	`3.61% <ø> (ø)`
@tanstack/query-persist-client-core	`57.73% <ø> (ø)`
@tanstack/query-sync-storage-persister	`84.61% <ø> (ø)`
@tanstack/react-query	`95.42% <ø> (ø)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`78.48% <ø> (ø)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`88.15% <ø> (ø)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`100.00% <ø> (ø)`
@tanstack/vue-query	`71.01% <ø> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* feat(eslint-plugin-query): implement no-void-query-fn rule * add docs * ci: apply automated fixes * build(eslint-plugin-query): switch from vite to tsup for building * update lockfile * revert lockfile * fix * fix publint * chore: add script to patch missing export equals * ci: apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Newbie012 and others added 4 commits March 30, 2025 10:50

feat(eslint-plugin-query): implement no-void-query-fn rule

40317f4

add docs

dacddd0

ci: apply automated fixes

1f19351

build(eslint-plugin-query): switch from vite to tsup for building

e82d782

github-actions bot added documentation Improvements or additions to documentation package: eslint-plugin-query labels Apr 1, 2025

Newbie012 added 3 commits April 1, 2025 17:15

Merge branch 'main' of github.com:TanStack/query into feat-no-void-qu…

1c2b4a9

…ery-fn-2

update lockfile

cf4af79

revert lockfile

51cc609

Newbie012 added 2 commits April 1, 2025 17:29

Merge branch 'main' into feat-no-void-query-fn-2

2af18c7

fix

9fc7c08

Newbie012 marked this pull request as ready for review April 1, 2025 14:30

Newbie012 changed the title ~~feat(eslint-plugin): no void queryFn [DO NOT MERGE]~~ feat(eslint-plugin): no void queryFn Apr 1, 2025

Newbie012 and others added 6 commits April 2, 2025 11:40

fix publint

9c00649

Merge branch 'main' into feat-no-void-query-fn-2

f70fe65

chore: add script to patch missing export equals

cf88d93

Merge branch 'feat-no-void-query-fn-2' of github.com:TanStack/query i…

f17fe39

…nto feat-no-void-query-fn-2

ci: apply automated fixes

e206886

Merge branch 'main' of github.com:TanStack/query into feat-no-void-qu…

9ee8ded

…ery-fn-2

TkDodo merged commit 993e838 into main Apr 7, 2025
7 checks passed

TkDodo deleted the feat-no-void-query-fn-2 branch April 7, 2025 09:17

joealden mentioned this pull request Apr 7, 2025

ESLint: Failed to load config "plugin:@tanstack/query/recommended" to extend from. #8968

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): no void queryFn #8925

feat(eslint-plugin): no void queryFn #8925

Newbie012 commented Apr 1, 2025 •

edited

Loading

nx-cloud bot commented Apr 1, 2025 •

edited

Loading

pkg-pr-new bot commented Apr 1, 2025 •

edited

Loading

github-actions bot commented Apr 1, 2025 •

edited

Loading

codecov bot commented Apr 7, 2025 •

edited

Loading

feat(eslint-plugin): no void queryFn #8925

feat(eslint-plugin): no void queryFn #8925

Conversation

Newbie012 commented Apr 1, 2025 • edited Loading

nx-cloud bot commented Apr 1, 2025 • edited Loading

pkg-pr-new bot commented Apr 1, 2025 • edited Loading

github-actions bot commented Apr 1, 2025 • edited Loading

codecov bot commented Apr 7, 2025 • edited Loading

Codecov Report

Newbie012 commented Apr 1, 2025 •

edited

Loading

nx-cloud bot commented Apr 1, 2025 •

edited

Loading

pkg-pr-new bot commented Apr 1, 2025 •

edited

Loading

github-actions bot commented Apr 1, 2025 •

edited

Loading

codecov bot commented Apr 7, 2025 •

edited

Loading