Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-query): remove unneccessary type assertion #8948

Closed
wants to merge 4 commits into from
Closed

fix(react-query): remove unneccessary type assertion #8948

wants to merge 4 commits into from
+1 −4

Conversation

minseong0324
Copy link
Contributor

@minseong0324 minseong0324 commented Apr 3, 2025 •
edited
Loading

The type assertion as QueryObserverOptions in client.defaultQueryOptions(opts) can be safely removed as TypeScript correctly infers the same type with or without the assertion.

Both cases result in the same type.

type of defaultedOptions

Without Type Assertion With Type Assertion
image image

type of opts

Without Type Assertion With Type Assertion
image image

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 2d66647.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 3m 12s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 59s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-04 13:39:58 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 3, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8948

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8948

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8948

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8948

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8948

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8948

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8948

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8948

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8948

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8948

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8948

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8948

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8948

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8948

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8948

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8948

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8948

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8948

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8948

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8948

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8948

commit: 2d66647

@minseong0324 minseong0324 marked this pull request as draft April 3, 2025 18:18
@minseong0324 minseong0324 marked this pull request as ready for review April 3, 2025 18:19
@TkDodo
Copy link
Collaborator

TkDodo commented Apr 6, 2025

seems like this doesn’t work. please check the error in nx:

https://cloud.nx.app/runs/R41jQAkcGu

@TkDodo TkDodo closed this Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minseong0324 @TkDodo