d3-color REDoS version patch #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overrides the version of d3-color used by d3-scale -> d3-interpolate to use 3.1.0, which remediates https://security.snyk.io/vuln/SNYK-JS-D3COLOR-1076592
|
Totally reasonable. 👍 |
|
🎉 This PR is included in version 3.0.0-beta.51 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi there - I am using dx-react-charts as a dependency which has a dependency on react-charts -> d3-scale -> d3-interpolate -> d3-color. Do i just add d3-color v3.1.0 as a peerDependency to fix this issue. Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overrides the version of d3-color used by d3-scale -> d3-interpolate to use 3.1.0, which remediates
https://security.snyk.io/vuln/SNYK-JS-D3COLOR-1076592
This addresses #328, and can be removed when d3/d3-interpolate#105 is reopened and merged.
LMK if there is a CLA or other formalities before merge. We are also patching in our install, but wanted to share more broadly in the meantime if this is a nit for react-charts users.