-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow throwing external redirects #2408
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6ff9169. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schiller-manuel the redirects in the router side of things are working as expected.
This however fails for Start, when a redirect
is thrown
/returned
from createServerFn
.
You'll likely want to take out lines 178-189 in start/server-handler/index.tsx
and resolve this in the router itself.
Edit: Also, you'll want to add a test to make sure redirects from createServerFn
calls are being handled.
a3957cb
to
6ff9169
Compare
i had to reopen it here #2429 |
No description provided.