Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow throwing external redirects #2408

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

schiller-manuel
Copy link
Contributor

No description provided.

Copy link

nx-cloud bot commented Sep 24, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6ff9169. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:eslint,test:unit,test:e2e,test:types,test:build,build --parallel=3

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Sep 24, 2024

Open in Stackblitz

More templates

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2408

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2408

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2408

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2408

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2408

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2408

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2408

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2408

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2408

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2408

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2408

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2408

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2408

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2408

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2408

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2408

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2408

commit: 6ff9169

@schiller-manuel schiller-manuel requested review from SeanCassiere and tannerlinsley and removed request for SeanCassiere September 24, 2024 17:53
Copy link
Member

@SeanCassiere SeanCassiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@schiller-manuel the redirects in the router side of things are working as expected.
This however fails for Start, when a redirect is thrown/returned from createServerFn.
You'll likely want to take out lines 178-189 in start/server-handler/index.tsx and resolve this in the router itself.

Edit: Also, you'll want to add a test to make sure redirects from createServerFn calls are being handled.

@schiller-manuel schiller-manuel merged commit 6ff9169 into main Sep 27, 2024
4 of 5 checks passed
@schiller-manuel schiller-manuel deleted the feat-external-redirects branch September 27, 2024 16:50
@schiller-manuel schiller-manuel restored the feat-external-redirects branch September 27, 2024 16:52
@schiller-manuel schiller-manuel deleted the feat-external-redirects branch September 27, 2024 16:53
@schiller-manuel
Copy link
Contributor Author

i had to reopen it here #2429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants