Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(start): better named exports for the start-vite-plugin #2794

Merged
merged 9 commits into from
Nov 22, 2024

Conversation

SeanCassiere
Copy link
Member

@SeanCassiere SeanCassiere commented Nov 18, 2024

Couldn't figure out the issues for cleansing the necessary code for client | server contexts, but did a bit of cleanup.

  • The start-vite-plugin package uses named exports for the individual plugins.
  • Fixes the start-supabase-basic example.

Copy link

nx-cloud bot commented Nov 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 127e371. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Nov 18, 2024

Open in Stackblitz

More templates

@tanstack/arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/arktype-adapter@2794

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2794

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2794

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2794

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2794

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2794

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2794

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2794

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2794

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2794

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2794

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2794

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2794

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2794

@tanstack/valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-adapter@2794

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2794

@tanstack/zod-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-adapter@2794

commit: 127e371

@SeanCassiere SeanCassiere marked this pull request as ready for review November 18, 2024 01:56
@SeanCassiere SeanCassiere marked this pull request as draft November 18, 2024 01:56
@SeanCassiere SeanCassiere changed the title fix(start): remove server references for createMiddleware in client bundle refactor(start): better named exports for the start-vite-plugin Nov 22, 2024
@SeanCassiere SeanCassiere marked this pull request as ready for review November 22, 2024 08:41
@SeanCassiere SeanCassiere merged commit 1f7700b into main Nov 22, 2024
5 checks passed
@SeanCassiere SeanCassiere deleted the fix/start-fn-middleware-dce branch November 22, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant