fix: extract props from validator issues #3708
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkazimierczak
changed the title
|
yes the docs update as mentioned makes sense! we should also add an e2e test for this, ideally using multiple standard schema compatible libraries. |
|
View your CI Pipeline Execution ↗ for commit 997261d.
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/create-router
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/create-start
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-api-routes
@tanstack/react-start-client
@tanstack/react-start-config
@tanstack/react-start-plugin
@tanstack/react-start-router-manifest
@tanstack/react-start-server
@tanstack/react-start-server-functions-client
@tanstack/react-start-server-functions-fetcher
@tanstack/react-start-server-functions-handler
@tanstack/react-start-server-functions-ssr
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-api-routes
@tanstack/solid-start-client
@tanstack/solid-start-config
@tanstack/solid-start-plugin
@tanstack/solid-start-router-manifest
@tanstack/solid-start-server
@tanstack/solid-start-server-functions-client
@tanstack/solid-start-server-functions-fetcher
@tanstack/solid-start-server-functions-handler
@tanstack/solid-start-server-functions-ssr
@tanstack/start
@tanstack/start-config
@tanstack/start-server-functions-server
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Summary
Replaces naive JSON serialization of validator issues by extracting known properties first, and then serializing extracted values instead of the error itself.
This makes is possible to avoid errors such as validation library having non-serializable errors.
Changes introduced based on the Discord discussion.
How
Introduces utilities provided by Standard Schema to the core package, adds
pathattribute which schema defines, exports the normalization function and uses it within theexecValidator.Result
The validation result is provided under message key in the error response:
{ "$error": { "message": "{\n \"root\": [\n \"must be an object (was a string)\"\n ],\n \"issues\": {}\n}", "stack": "... error stacktrace ...", "cause": { "$undefined": 0 } } }The validation result is split into two parts - root and issues.
rootaggregates all validation messages that happened at the root (as explained in When is Issue.path allowed to be undefined? #60), whileissuescontains all errors for which thepathwas present.Future Work
Docs
Maybe it would be good to reword a docs, to mention that
validatorintegrate seamlessly with external validators, that implement Standard Schema?