-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F/add deployment script #37
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added 2 pending comments
"ethereum-waffle": "^3.4.4", | ||
"ethers": "^5.6.6", | ||
"hardhat": "^2.9.5", | ||
"hardhat-gas-reporter": "^1.0.8" | ||
"hardhat-gas-reporter": "^1.0.8", | ||
"sol-merger": "^4.1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you add sol-merger ? you can compile the contracts with hardhat compile
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added sol-merger to flatten the contracts in order to manually verify them on etherscan. I had some issues verifying some contracts programatically through hardhat-etherscan.js
const swapper = await Swapper.deploy() | ||
await swapper.deployed() | ||
console.log('Swapper deployed to: ', swapper.address) | ||
console.log('IMPORTANT: Add swapper address to /packages/hardhat/src/addresses.js') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could code the addition of the src addresses directly from this file so that you don't need to add it manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I missed this. Will repair it
the branch has some conflicts with dev branch. Please resolves conflicts locally and push again. Here is what i get when i
|
Thanks for this thorough review. I'll modify the hardhat scripts to update the constant variables in address.js and I'll make another attempt at rebasing correctly. I'll let you know if I have any difficulties. |
No description provided.