feat(query-repository): add missing methods with 'asNoTracking' parameter to 'QueryRepository' (#55)

[dmitrii-kiselev]

Closes #55

[dmitrii-kiselev]

Hi @TanvirArjel,

Please take a look at my pull request when you have some free time.
It will add some critical missing features.

Best Regards,
Dmitrii Kiselev

[dmitrii-kiselev]

Hi @TanvirArjel,

I apologize if I distract you from your work.
Have you had a chance to see my contributions to this wonderful project?
If you have any comments, please write and I will fix everything.

I also noticed that you have a dev branch.
I assume that all new developments should be merged there first.
I apologize, I did not notice this beforehand, as it was not described on the project homepage.
If it's critical, I can recreate pull requests to merge the commit to the dev branch.

Please look at the created pull requests and give you feedback, these features are needed for this project!

I have many ideas on how to improve this project.
I would be very happy to help you support it and continue contributing to this project.

Best Regards,
Dmitrii Kiselev

[TanvirArjel]

@dmitrii-kiselev If any query contains a select expression, the entity framework core does not track by default. This is why I have avoided those overloads.

[dmitrii-kiselev]

Hi @TanvirArjel,

Thank you for your feedback.
In this case, we need to leave only one overload for PaginationSpecification<T>, which is missing from the code:

/// <summary>
/// This method returns a <see cref="PaginatedList{T}"/>.
/// </summary>
/// <typeparam name="TEntity">The type of the entity.</typeparam>
/// <param name="specification">An object of <see cref="PaginationSpecification{T}"/>.</param>
/// <param name="asNoTracking">A <see cref="bool"/> value which determines whether the return entity will be tracked by
/// EF Core context or not. Default value is false i.e tracking is enabled by default.
/// </param>
/// <param name="cancellationToken"> A <see cref="CancellationToken"/> to observe while waiting for the task to complete.</param>
/// <returns>Returns <see cref="PaginatedList{T}"/>.</returns>
/// <exception cref="ArgumentNullException">Thrown if <paramref name="specification"/> is smaller than 1.</exception>
Task<PaginatedList<TEntity>> GetListAsync<TEntity>(
    PaginationSpecification<TEntity> specification,
    bool asNoTracking,
    CancellationToken cancellationToken = default)
    where TEntity : class;

There is only one:

EFCore.GenericRepository/src/TanvirArjel.EFCore.QueryRepository/QueryRepository.cs

Line 219 in bda2598

public async Task<PaginatedList<T>> GetListAsync<T>(

But for Specification<T> there are both:

EFCore.GenericRepository/src/TanvirArjel.EFCore.QueryRepository/QueryRepository.cs

Line 130 in bda2598

public Task<List<T>> GetListAsync<T>(Specification<T> specification, CancellationToken cancellationToken = default)

EFCore.GenericRepository/src/TanvirArjel.EFCore.QueryRepository/QueryRepository.cs

Line 136 in bda2598

public async Task<List<T>> GetListAsync<T>(

It is also necessary to add your thoughts about select expression on the wiki page or the project's home page.
I'll fix the code to leave one missing overload and let you know when it's done.

Best Regards,
Dmitrii Kiselev

[dmitrii-kiselev]

Hi @TanvirArjel,

I fixed the code so it only contains the missing overload for PaginationSpecification<TEntity>.
Please review and provide your feedback.

Best Regards,
Dmitrii Kiselev

[dmitrii-kiselev]

Hi @TanvirArjel,

Can we merge this, please?

Best Regards,
Dmitrii Kiselev