Closes #2608: Remove SpringRestDocs as it has been replaced with OpenAPI #2641

jamesrdi · 2024-08-06T14:02:12Z

Thanks for your PR! Please fill out the following list :)

I put the ticket or multiple tickets in review
Commit message format → Closes #<Issue Number> - Your commit message.
Sonarcloud link : <add the link here>
No documentation update needed
Link to PR with documentation update: <add the link here>
No Release Notes needed
Release Notes :

…nup job

Bumps [org.apache.maven.plugins:maven-jar-plugin](https://github.com/apache/maven-jar-plugin) from 3.4.0 to 3.4.1. - [Release notes](https://github.com/apache/maven-jar-plugin/releases) - [Commits](apache/maven-jar-plugin@maven-jar-plugin-3.4.0...maven-jar-plugin-3.4.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-jar-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps com.oracle.database.jdbc:ojdbc8 from 23.3.0.23.09 to 23.4.0.24.05. --- updated-dependencies: - dependency-name: com.oracle.database.jdbc:ojdbc8 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps `version.aspectj` from 1.9.22 to 1.9.22.1. Updates `org.aspectj:aspectjtools` from 1.9.22 to 1.9.22.1 - [Release notes](https://github.com/eclipse/org.aspectj/releases) - [Commits](https://github.com/eclipse/org.aspectj/commits) Updates `org.aspectj:aspectjrt` from 1.9.22 to 1.9.22.1 - [Release notes](https://github.com/eclipse/org.aspectj/releases) - [Commits](https://github.com/eclipse/org.aspectj/commits) --- updated-dependencies: - dependency-name: org.aspectj:aspectjtools dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.aspectj:aspectjrt dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps `version.testcontainers` from 1.19.7 to 1.19.8. Updates `org.testcontainers:db2` from 1.19.7 to 1.19.8 - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.19.7...1.19.8) Updates `org.testcontainers:oracle-xe` from 1.19.7 to 1.19.8 - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.19.7...1.19.8) Updates `org.testcontainers:postgresql` from 1.19.7 to 1.19.8 - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.19.7...1.19.8) --- updated-dependencies: - dependency-name: org.testcontainers:db2 dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: org.testcontainers:oracle-xe dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.testcontainers:postgresql dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps org.sonatype.plugins:nexus-staging-maven-plugin from 1.6.13 to 1.7.0. --- updated-dependencies: - dependency-name: org.sonatype.plugins:nexus-staging-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.6.3 to 3.7.0. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.6.3...maven-javadoc-plugin-3.7.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-javadoc-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.apache.maven.plugins:maven-gpg-plugin](https://github.com/apache/maven-gpg-plugin) from 3.2.3 to 3.2.4. - [Release notes](https://github.com/apache/maven-gpg-plugin/releases) - [Commits](apache/maven-gpg-plugin@maven-gpg-plugin-3.2.3...maven-gpg-plugin-3.2.4) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-gpg-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [jakarta.servlet:jakarta.servlet-api](https://github.com/eclipse-ee4j/servlet-api) from 6.0.0 to 6.1.0. - [Commits](https://github.com/eclipse-ee4j/servlet-api/commits) --- updated-dependencies: - dependency-name: jakarta.servlet:jakarta.servlet-api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [andymckay/cancel-action](https://github.com/andymckay/cancel-action) from 0.4 to 0.5. - [Release notes](https://github.com/andymckay/cancel-action/releases) - [Commits](andymckay/cancel-action@0.4...0.5) --- updated-dependencies: - dependency-name: andymckay/cancel-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.apache.maven.plugins:maven-jar-plugin](https://github.com/apache/maven-jar-plugin) from 3.4.1 to 3.4.2. - [Release notes](https://github.com/apache/maven-jar-plugin/releases) - [Commits](apache/maven-jar-plugin@maven-jar-plugin-3.4.1...maven-jar-plugin-3.4.2) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-jar-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.2.5 to 3.3.0. - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.2.5...surefire-3.3.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.3.0 to 3.3.1. - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.3.0...surefire-3.3.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.apache.maven.plugins:maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin) from 3.6.1 to 3.7.1. - [Release notes](https://github.com/apache/maven-dependency-plugin/releases) - [Commits](apache/maven-dependency-plugin@maven-dependency-plugin-3.6.1...maven-dependency-plugin-3.7.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-dependency-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [ws](https://github.com/websockets/ws) from 7.5.9 to 7.5.10. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.5.9...7.5.10) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.apache.maven.plugins:maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.3.1 to 3.4.0. - [Commits](apache/maven-checkstyle-plugin@maven-checkstyle-plugin-3.3.1...maven-checkstyle-plugin-3.4.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-checkstyle-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.jacoco:jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.11 to 0.8.12. - [Release notes](https://github.com/jacoco/jacoco/releases) - [Commits](jacoco/jacoco@v0.8.11...v0.8.12) --- updated-dependencies: - dependency-name: org.jacoco:jacoco-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4.0.2...v4.0.3) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps `version.testcontainers` from 1.19.8 to 1.20.0. Updates `org.testcontainers:db2` from 1.19.8 to 1.20.0 - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.19.8...1.20.0) Updates `org.testcontainers:oracle-xe` from 1.19.8 to 1.20.0 - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.19.8...1.20.0) Updates `org.testcontainers:postgresql` from 1.19.8 to 1.20.0 - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.19.8...1.20.0) --- updated-dependencies: - dependency-name: org.testcontainers:db2 dependency-type: direct:development update-type: version-update:semver-minor - dependency-name: org.testcontainers:oracle-xe dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.testcontainers:postgresql dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.7.0 to 3.8.0. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.7.0...maven-javadoc-plugin-3.8.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-javadoc-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: SebastianRoseneck <[email protected]> Co-authored-by: ryzheboka <[email protected]>

Bumps com.oracle.database.jdbc:ojdbc8 from 23.4.0.24.05 to 23.5.0.24.07. --- updated-dependencies: - dependency-name: com.oracle.database.jdbc:ojdbc8 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

jamesrdi · 2024-08-06T14:03:12Z

Should wait until #2622 is merged

holgerhagen · 2024-08-06T15:45:15Z

...est-spring/src/main/java/pro/taskana/simplehistory/rest/TaskHistoryQueryFilterParameter.java

  @JsonProperty("event-type")
  private final String[] eventType;

-  /**
-   * Filter by the event type of the Task History Event. This results in a substring search.. (% is


Where did this information go? Or do we simply delete it?

This information is copied as OpenAPI annotation in #2622, that is why I have to wait until #2622 is merged, then I will rebase it

holgerhagen · 2024-08-06T16:02:06Z

...g/src/main/java/pro/taskana/workbasket/rest/models/WorkbasketSummaryRepresentationModel.java

  @Schema(name = "orgLevel3", description = "The third Org Level.")
  protected String orgLevel3;

-  /** The fourth Org Level (the lowest one). */
  @Schema(name = "orgLevel4", description = "The fourth Org Level.")
  protected String orgLevel4;

  /** Identifier to tell if this workbasket can be deleted. */


this line needs to be deleted as well?

Yes you are right, I will delete it

… with SB 3.2

…onnections simultaneously -Write operations are now performed with the regular TaskanEngine and its' SqlSession and TransactionFactory which provides the needed transactionality and doesn't open multiple connections

…he of underlying SQL session

…w use case "owner-is-null=true"

…th OpenAPI

ryzheboka and others added 27 commits April 23, 2024 13:12

Closes Taskana#2506 - fix deleting DELETED history events by the clea…

8593221

…nup job

Closes Taskana#2604 - updated assertJ code to remove deprecation notices

860d5fc

Closes Taskana#2610 - fixed encoding configuration for checkstyle plugin

4dd52b8

Closes Taskana#2563 - add handling of permissions as access ids

31100a5

Co-authored-by: SebastianRoseneck <[email protected]> Co-authored-by: ryzheboka <[email protected]>

Closes Taskana#2446 - change the pull request template

f70bfd0

Closes Taskana#2638: Use "docker compose" instead of "docker-compose"

611a735

holgerhagen requested changes Aug 6, 2024

View reviewed changes

Closes Taskana#2486 : Upgrade to Spring Boot 3.2

a3e4552

arolfes and others added 6 commits August 7, 2024 10:28

Closes Taskana#2486 : Upgrade to Wildfly 31.0.1.Final to make it work…

f1751a6

… with SB 3.2

Closes Taskana#2624 SpringBoot 3.3.1

4e1325c

Review Findings

46ab785

Closes Taskana#2634: Add TaskanaEngine.clearSessionCache to clear cac…

4f8e8ba

…he of underlying SQL session

Closes Taskana#2635: Make owner-is-null=owner-is-null not valid, allo…

4f45dfd

…w use case "owner-is-null=true"

jamesrdi force-pushed the TSK-2608 branch from e54d06a to 387013e Compare August 7, 2024 10:24

mustaphazorgati and others added 3 commits August 7, 2024 13:35

Updated poms to version 8.1.1-SNAPSHOT

596a686

Closes Taskana#2486: Conversion to open api doc

712abf4

Closes Taskana#2616 - Make OpenAPI/Swagger UI docs public

bbad969

jamesrdi force-pushed the TSK-2608 branch 3 times, most recently from 025da7c to 233b660 Compare August 7, 2024 12:02

Closes Taskana#2608: Remove SpringRestDocs as it has been replaced wi…

233b660

…th OpenAPI

jamesrdi mentioned this pull request Aug 7, 2024

Closes #2608: Remove SpringRestDocs as it has been replaced with OpenAPI #2647

Merged

7 tasks

jamesrdi closed this Aug 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Closes #2608: Remove SpringRestDocs as it has been replaced with OpenAPI #2641

Closes #2608: Remove SpringRestDocs as it has been replaced with OpenAPI #2641

jamesrdi commented Aug 6, 2024 •

edited

Loading

jamesrdi commented Aug 6, 2024

holgerhagen Aug 6, 2024

jamesrdi Aug 7, 2024

holgerhagen Aug 6, 2024

jamesrdi Aug 7, 2024

Closes #2608: Remove SpringRestDocs as it has been replaced with OpenAPI #2641

Closes #2608: Remove SpringRestDocs as it has been replaced with OpenAPI #2641

Conversation

jamesrdi commented Aug 6, 2024 • edited Loading

Thanks for your PR! Please fill out the following list :)

jamesrdi commented Aug 6, 2024

holgerhagen Aug 6, 2024

Choose a reason for hiding this comment

jamesrdi Aug 7, 2024

Choose a reason for hiding this comment

holgerhagen Aug 6, 2024

Choose a reason for hiding this comment

jamesrdi Aug 7, 2024

Choose a reason for hiding this comment

jamesrdi commented Aug 6, 2024 •

edited

Loading