Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Christmas Chaplain Presents #13636

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Deahaka
Copy link
Contributor

@Deahaka Deahaka commented Nov 15, 2024

Описание изменений

на новый год боги священников могут дарить новогодние подарки своими заклинаниями

Почему и что этот ПР улучшит

поощрение интересных ситуаций взаимоигрой

Авторство

звуки с фрисаунда

Чеинжлог

@TauKitty
Copy link
Contributor

Changelog status: 🔘 No changelog


clothes_req = FALSE

action_icon_state = "spawn_bible"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может иконку подарка сюда сунуть, а не библии?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

выглядит и так норм

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Иконка библии срет подарок???? хуйня же

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Там красивая экшн иконка

/obj/effect/proc_holder/spell/no_target/god_gift/cast(list/targets, mob/user = usr)
var/turf/spawn_turf = get_turf(user)

for(var/mob/living/carbon/human/M in viewers(spawn_turf, world.view))
Copy link
Member

@KIBORG04 KIBORG04 Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for(var/mob/living/carbon/human/M in viewers(spawn_turf, world.view))
for(var/mob/living/M in viewers(spawn_turf, world.view))

Граунд контрол ту мейджор тоом

Copy link
Contributor Author

@Deahaka Deahaka Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут до ливинг сократить разве что можно
upd. ну вообще нет, зачем. боги бывают ток у людей, ты обезянам посохи не давал. знач на людей применяем любой эффект

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Эээ, а не похуй кого слепить? Это же ослепление всех, кто видит.

Функция есть у всех, начиная с ливингов, мб и вызывать у всех ливингов? Зач ток людей
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сделал на карбонов, ливинги это ещё и божки, а его слепить не надо.

if(!global.possible_gifts.len)
var/list/gift_types_list = subtypesof(/obj/item)
for(var/obj/item/I as anything in gift_types_list)
if(I.flags & ABSTRACT)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(I.flags & ABSTRACT)
if(I::flags & ABSTRACT)

Может тогда такой оператор заюзать? Ответ не изменится, но поидее будет понятнее

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сделал через initial()

Copy link
Member

@KIBORG04 KIBORG04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Все что реально напрягает меня здесь - иконка библии у спелла. Даже как-то всё равно на АБСОЛЮТНО РАНДОМНЫЙ АЙТЕМ раз в 2 минуты

@TauKitty TauKitty requested a review from a team November 20, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants