Remove traceback, raise instead

modules/bilibili/bili_api.py

@@ -1,7 +1,4 @@
-import traceback
-
 from core.builtins import Bot, Embed, EmbedField, ErrorMessage, Image, Plain, Url
-from core.logger import Logger
 from core.utils.http import get_url
 from core.utils.web_render import webrender
 
@@ -23,7 +20,7 @@ async def get_video_info(msg: Bot.MessageSession, query, get_detail=False, use_e
         if str(e).startswith('412'):
             await msg.finish(ErrorMessage('{bilibili.message.error.rejected}', locale=msg.locale.locale))
         else:
-            Logger.error(traceback.format_exc())
+            raise e
 
     view = res['data']['View']
     stat = view['stat']

modules/bugtracker/bugtracker.py

@@ -1,5 +1,4 @@
 import os
-import traceback
 
 import aiohttp
 import ujson as json
@@ -59,7 +58,7 @@ async def bugtracker_get(msg, mojira_id: str):
         if str(e).startswith('401'):
             return msg.locale.t("bugtracker.message.get_failed"), None
         else:
-            Logger.error(traceback.format_exc())
+            raise e
     if mojira_id not in spx_cache:
         get_spx = await get_url('https://spxx-db.teahouse.team/crowdin/zh-CN/zh_CN.json', 200)
         if get_spx:

modules/cytoid/profile.py

@@ -1,9 +1,6 @@
-import traceback
-
 import ujson as json
 
 from core.builtins import Bot, Image, Plain
-from core.logger import Logger
 from core.utils.http import get_url
 from .dbutils import CytoidBindInfoManager
 
@@ -23,7 +20,7 @@ async def cytoid_profile(msg: Bot.MessageSession):
         if str(e).startswith('404'):
             await msg.finish(msg.locale.t('cytoid.message.user_not_found'))
         else:
-            Logger.error(traceback.format_exc())
+            raise e
     uid = profile['user']['uid']
     nick = profile['user']['name']
     avatar = profile['user']['avatar']['large']

modules/github/repo.py

@@ -1,10 +1,6 @@
-import asyncio
-import traceback
-
 from core.builtins import Bot, Image, Plain, Url
 from core.dirty_check import rickroll
-from core.logger import Logger
-from core.utils.http import get_url
+from core.utils.http import download, get_url
 from modules.github.utils import time_diff, dirty_check, darkCheck
 
 
@@ -59,16 +55,13 @@ async def repo(msg: Bot.MessageSession, name: str):
         else:
             await msg.send_message([Plain(message)])
 
-            async def download():
-                download_pic = await download(
-                    f'https://opengraph.githubassets.com/c9f4179f4d560950b2355c82aa2b7750bffd945744f9b8ea3f93cc24779745a0/{result["full_name"]}')
-                if download_pic:
-                    await msg.finish([Image(download_pic)], quote=False)
-
-            asyncio.create_task(download())
+        download_pic = await download(
+            f'https://opengraph.githubassets.com/c9f4179f4d560950b2355c82aa2b7750bffd945744f9b8ea3f93cc24779745a0/{result["full_name"]}')
+        if download_pic:
+            await msg.finish([Image(download_pic)], quote=False)
 
     except ValueError as e:
         if str(e).startswith('404'):
             await msg.finish(msg.locale.t("github.message.repo.not_found"))
         else:
-            Logger.error(traceback.format_exc())
+            raise e

modules/github/user.py

@@ -1,8 +1,5 @@
-import traceback
-
 from core.builtins import Url, Bot
 from core.dirty_check import rickroll
-from core.logger import Logger
 from core.utils.http import get_url
 from modules.github.utils import time_diff, dirty_check, darkCheck
 
@@ -48,4 +45,4 @@ async def user(msg: Bot.MessageSession, name: str):
         if str(e).startswith('404'):
             await msg.finish(msg.locale.t("github.message.repo.not_found"))
         else:
-            Logger.error(traceback.format_exc())
+            raise e

modules/osu/profile.py

@@ -6,7 +6,6 @@
 from config import Config
 from core.builtins import Bot
 from core.exceptions import ConfigValueError
-from core.logger import Logger
 from core.utils.http import get_url
 
 
@@ -65,7 +64,7 @@ async def osu_profile(msg: Bot.MessageSession, uid, mode):
         if str(e).startswith('401'):
             raise ConfigValueError(msg.locale.t("error.config.invalid"))
         else:
-            Logger.error(traceback.format_exc())
+            raise e
     except Exception:
         Logger.error(traceback.format_exc())
         await msg.finish(msg.locale.t('osu.message.not_found'))

modules/tweet/__init__.py

@@ -1,13 +1,11 @@
 import re
-import traceback
 
 import ujson as json
 
 from core.builtins import Bot
 from core.builtins.message import Image, Url
 from core.component import module
 from core.dirty_check import check_bool, rickroll
-from core.logger import Logger
 from core.utils.http import download, get_url
 from core.utils.text import isint
 from core.utils.web_render import webrender
@@ -41,7 +39,7 @@ async def _(msg: Bot.MessageSession, tweet: str):
         if str(e).startswith('404'):
             await msg.finish(msg.locale.t('tweet.message.invalid'))
         else:
-            Logger.error(traceback.format_exc())
+            raise e
 
     res_json = json.loads(res)
     if not res_json['data']:

modules/wolframalpha/__init__.py

@@ -1,5 +1,4 @@
 import os
-import traceback
 import urllib.parse
 from PIL import Image
 
@@ -8,7 +7,6 @@
 from core.component import module
 from core.dirty_check import rickroll
 from core.exceptions import ConfigValueError
-from core .logger import Logger
 from core.utils.http import download, get_url
 from .check import secret_check
 
@@ -44,7 +42,7 @@ async def _(msg: Bot.MessageSession, query: str):
         if str(e).startswith('501'):
             await msg.finish(msg.locale.t('wolframalpha.message.incomprehensible'))
         else:
-            Logger.error(traceback.format_exc())
+            raise e
 
 
 @w.handle('ask <question> {{wolframalpha.help.ask}}')
@@ -62,4 +60,4 @@ async def _(msg: Bot.MessageSession, question: str):
         if str(e).startswith('501'):
             await msg.finish(msg.locale.t('wolframalpha.message.incomprehensible'))
         else:
-            Logger.error(traceback.format_exc())
+            raise e