Skip to content

Commit

Permalink
refactor: 필요없는 service 제거 (banner)
Browse files Browse the repository at this point in the history
  • Loading branch information
suw0n committed Aug 21, 2024
1 parent b4f835d commit ce75855
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 51 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
package b1nd.dodam.restapi.banner.application;

import b1nd.dodam.domain.rds.banner.entity.Banner;
import b1nd.dodam.domain.rds.banner.service.BannerService;
import b1nd.dodam.domain.rds.banner.enumeration.BannerStatus;
import b1nd.dodam.domain.rds.banner.repository.BannerRepository;
import b1nd.dodam.restapi.banner.application.data.req.BannerReq;
import b1nd.dodam.restapi.support.data.Response;
import b1nd.dodam.restapi.support.data.ResponseData;
Expand All @@ -16,49 +17,49 @@
@RequiredArgsConstructor
public class BannerUseCase {

private final BannerService service;
private final BannerRepository repository;

public Response create(BannerReq req) {
service.save(req.mapToBanner());
repository.save(req.mapToBanner());
return Response.created("배너 생성 성공");
}

public Response modify(int id, BannerReq req) {
Banner banner = service.getById(id);
Banner banner = repository.getById(id);
banner.updateBanner(req.title(), req.image(), req.url(), req.expireAt());
return Response.noContent("배너 수정 성공");
}

public Response activate(int id) {
Banner banner = service.getById(id);
Banner banner = repository.getById(id);
banner.activateStatus();
return Response.noContent("배너 활성화 성공");
}

public Response deactivate(int id) {
Banner banner = service.getById(id);
Banner banner = repository.getById(id);
banner.deactivateStatus();
return Response.noContent("배너 비활성화 성공");
}

public Response deleteById(int id) {
service.deleteById(id);
repository.deleteById(id);
return Response.noContent("배너 삭제 성공");
}

@Transactional(readOnly = true)
public ResponseData<Banner> getById(int id) {
return ResponseData.ok("배너 단일 조회 성공", service.getById(id));
return ResponseData.ok("배너 단일 조회 성공", repository.getById(id));
}

@Transactional(readOnly = true)
public ResponseData<List<Banner>> getActivates() {
return ResponseData.ok("활성화 배너 조회 성공", service.getActivates());
return ResponseData.ok("활성화 배너 조회 성공", repository.findByStatusOrderByIdDesc(BannerStatus.ACTIVE));
}

@Transactional(readOnly = true)
public ResponseData<List<Banner>> getAllOrderByIdDesc() {
return ResponseData.ok("배너 전체 조회 성공", service.getAllOrderByIdDesc());
return ResponseData.ok("배너 전체 조회 성공", repository.findAllByOrderByIdDesc());
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import b1nd.dodam.domain.rds.banner.entity.Banner;
import b1nd.dodam.domain.rds.banner.enumeration.BannerStatus;
import b1nd.dodam.domain.rds.banner.exception.BannerNotFoundException;
import org.springframework.data.jpa.repository.JpaRepository;

import java.util.List;
Expand All @@ -12,4 +13,9 @@ public interface BannerRepository extends JpaRepository<Banner, Integer> {

List<Banner> findByStatusOrderByIdDesc(BannerStatus bannerStatus);

default Banner getById(int id) {
return findById(id)
.orElseThrow(BannerNotFoundException::new);
}

}

This file was deleted.

0 comments on commit ce75855

Please sign in to comment.