Parse osu!.db #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One more thing, I just realized I never yield back to the event loop, so the progress bar doesn't get updated. You should await something every so often or the update() calls will be useless. Also for speed, you could skip bytes that you're not using. Like the stars of every mod of every ruleset for example. |
|
I am going to return to this PR after I am done documenting most of the codebase. |
kiwec
commented
Sep 30, 2024
| return none(); | ||
| } | ||
|
|
||
| return some(path.join(process.env.LOCALAPPDATA, "osu!", "Songs")); |
There was a problem hiding this comment.
osu!.db is in the "osu!" directory, not in "osu!/Songs"
To be clear, users should select the "osu!" directory not the "Songs" directory
2 tasks
|
"merged" in #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates some issues, see comments. I won't work on this further so you're free to take over the PR.
Also: consider reloading the db on every start, to be in sync with the game. Right now it's only loaded once, and then never checked again.