Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/product api #67

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Feature/product api #67

merged 6 commits into from
Jun 21, 2024

Conversation

lvolzdev
Copy link
Contributor

@lvolzdev lvolzdev commented Jun 21, 2024 •
edited
Loading

πŸ“„ Summary

  • Get products owned

✏️ Describe your changes

  • Get Products owned by normal user (pagination)
  • Get Products owned by corp user (pagination)
  • add SearchConditions schema

πŸ“ Issue number and link

@lvolzdev lvolzdev self-assigned this Jun 21, 2024
bkkmw
bkkmw reviewed Jun 21, 2024
View reviewed changes
applications/product-application/src/main/java/com/pda/productapplication/dto/ProductDto.java Outdated
private int boardCount;
@Schema(description = "Created time", example = "2024-06-20 16:23:47.000000")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example에 Tκ°€ 빠진 것 κ°™μŠ΅λ‹ˆλ‹€

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

bkkmw
bkkmw reviewed Jun 21, 2024
View reviewed changes
...ct-application/src/main/java/com/pda/productapplication/repository/ProductSpecification.java Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bkkmw
bkkmw reviewed Jun 21, 2024
View reviewed changes
...ons/product-application/src/main/java/com/pda/productapplication/service/ProductService.java
import java.util.Collections;
import java.util.List;
import java.util.Optional;
import java.util.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#68

This was referenced Jun 21, 2024
Closed
Closed
@lvolzdev lvolzdev merged commit fe1a44c into develop Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkkmw bkkmw bkkmw left review comments

Assignees

@lvolzdev lvolzdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lvolzdev @bkkmw