Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check to make sure the code doesn't crash if motors are unplugged #20

Open
jkleiber opened this issue Dec 22, 2022 · 0 comments
Open

Check to make sure the code doesn't crash if motors are unplugged #20

jkleiber opened this issue Dec 22, 2022 · 0 comments
Assignees
Labels
investigation Investigate something

Comments

@jkleiber
Copy link
Contributor

Summary
During the FRC 2020 season we learned that the motors are set to null in Java if the motors are not detected on the CAN bus. For 2020 and 2022, we mitigated this by simply not doing the motor commands if a given motor is null.

With the move to C++ and our separation of hardware I/O from software logic, it should be even easier to avoid causing problems if the motors are unplugged. However, in C++ things don't normally just get set to null. Perhaps the motors are nullptr if they are unplugged, but this probably won't be well known until we try the code on actual hardware.

Work to Do

  • Test the code on actual hardware and see if we get weird errors
  • Find mitigation for any anomalies we come across during the initial hardware test
  • Verify that the I/O classes are set up with correct safeguards to avoid spams

Verification

  • No spam when things are unplugged
  • Work is done
  • CI passes
@jkleiber jkleiber added the investigation Investigate something label Dec 22, 2022
@danielbrownmsm danielbrownmsm added this to the Previous Functionality milestone Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigation Investigate something
Projects
None yet
Development

No branches or pull requests

2 participants