Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters for hardware configuration to TOML file #22

Open
jkleiber opened this issue Jan 15, 2023 · 3 comments
Open

Add parameters for hardware configuration to TOML file #22

jkleiber opened this issue Jan 15, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jkleiber
Copy link
Contributor

Summary
Hardware configurations and limits need to be added to the parameters.toml file.

Items to add:

  • Current limit
  • Max output
  • Open loop ramp rate

Work

  • Add the hardware configuration to the parameters.toml file in appropriate sections

Verification

  • CI passes
  • Parameters updated correctly

Deferred Work
Adding the following is deferred until we can figure out how to integrate parameter loading in CI:

  • Motor/Sensor CAN IDs
  • Motor/Sensor roboRIO input channels
@jkleiber jkleiber added the enhancement New feature or request label Jan 15, 2023
@jkleiber jkleiber added this to the Base Actions milestone Jan 15, 2023
@jkleiber
Copy link
Contributor Author

@AbbeySieg what's the status on this? Do you feel like you can take this task on? I'll assign it to you for now

@AbbeySieg
Copy link
Contributor

I'm not sure if Daniel or Noah updated you, but the unit tests for the arm were not pulling the PID values from the parameters.toml file. We figured out how to make the unit tests pass. As long as someone tells me what to for this task I am able to do it.

@jkleiber
Copy link
Contributor Author

@danielbrownmsm @noahzemlin @AbbeySieg the parameters not being pulled is a known issue (by me at least) from the beta test. The issue is that the deploy directory doesn't get copied to the unit test execution location. I had some hacks on the beta repo to fix this, but I would recommend disabling such unit tests or setting appropriate default values

@danielbrownmsm danielbrownmsm added long-term stuff that we don't necessarily have to do right now and removed long-term stuff that we don't necessarily have to do right now labels Apr 4, 2023
@X-EX3-X X-EX3-X self-assigned this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants