Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”— :: (#891) μ§€μ›μš”μ²­ μ€‘λ³΅μ²˜λ¦¬ μˆ˜μ • #892

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

πŸ”— :: (#891) μ§€μ›μš”μ²­ μ€‘λ³΅μ²˜λ¦¬ μˆ˜μ • #892

wants to merge 2 commits into from
+5 βˆ’6

Conversation

uyjeamin
Copy link
Contributor

@uyjeamin uyjeamin commented Mar 13, 2025 •
edited
Loading

μž‘μ—… λ‚΄μš© μ„€λͺ…

  • μ§€μ›μš”μ²­ μ€‘λ³΅μœΌλ‘œ μ²˜λ¦¬λ˜λŠ” 였λ₯˜ μˆ˜μ •
  • selectOne() 으둜 쿼리 μ΅œμ ν™”

결과물(있으면)

체크리슀트

  • μ–΄ν”Œλ¦¬μΌ€μ΄μ…˜ ꡬ동(ν˜Ήμ€ ν…ŒμŠ€νŠΈ)μ‹œ 였λ₯˜λŠ” μ—†λ‚˜μš”?
  • DDL이 λ³€κ²½λ˜μ—ˆμ„ 경우 flyway λ§ˆμ΄κ·Έλ ˆμ΄μ…˜ 슀크립트λ₯Ό μž‘μ„±ν•˜μ˜€λ‚˜μš”?
  • μƒμ„±λœ μ½”λ“œμ— λŒ€ν•œ ν…ŒμŠ€νŠΈ μ½”λ“œκ°€ μž‘μ„± λ˜μ—ˆλ‚˜μš”?

κ΄€λ ¨ 이슈

@uyjeamin uyjeamin self-assigned this Mar 13, 2025
@uyjeamin uyjeamin requested a review from a team as a code owner March 13, 2025 07:52
geunoo
geunoo reviewed Mar 13, 2025
View reviewed changes
...main/java/team/retum/jobis/domain/application/persistence/ApplicationPersistenceAdapter.java
Comment on lines +314 to 315
.selectOne()
.from(applicationEntity)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selectFrom은 μ–΄λ–€κ°€μš©

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selectForm 이 select(application).from(applicationEntity) 의 쀄인 ν‘œν˜„μœΌλ‘œ μ•„λŠ”λ° 이것 말고 selectOne() 을 μ¨μ„œ exsist 검증 ν•˜λŠ” λ‘œμ§μ„ 짜면 더 μ΅œμ ν™”κ°€ λœλ‹€κ³  μ•Œκ³  μžˆμ–΄μ„œ μ΄λ ‡κ²Œ μ§œλ΄€μŠ΅λ‹ˆλ‹€

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geunoo geunoo geunoo left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@uyjeamin uyjeamin

Labels
κΈ°λŠ₯ μˆ˜μ • 버그 μˆ˜μ •
Projects
μŠ€ν”„λ¦°νŠΈ 2κΈ°
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

μ§€μ›μš”μ²­ 쀑볡 νŒλ‹¨ 쿼리성λŠ₯κ°œμ„  및 μˆ˜μ •
2 participants
@uyjeamin @geunoo