Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct class cast at color selection dialog #3901

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Correct class cast at color selection dialog #3901

merged 1 commit into from
Aug 12, 2023

Conversation

TranceLove
Copy link
Collaborator

Description

To fix the incorrect class cast at color selection dialog.

Issue tracker

Fixes #3900

Automatic tests

  • Added test cases

Manual tests

  • Done

Device:

  • Galaxy Nexus emulator running Android 4.4
  • Pixel 6 emulator running Android 13

There should be no crash when choosing UI colors, either preset, custom or random colors.

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

@TranceLove TranceLove added Issue-Bug Related unexpected behavior or something worth investigating. Area-UIUX Related to user interface/experience (e.g. dialogs, notifications). Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. From-telegram Issue reported through telegram channel labels Aug 8, 2023
@TranceLove TranceLove added this to the v4.0 milestone Aug 8, 2023
@VishalNehra VishalNehra merged commit 671d0df into release/4.0 Aug 12, 2023
3 of 4 checks passed
@VishnuSanal VishnuSanal mentioned this pull request Aug 13, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VishnuSanal VishnuSanal VishnuSanal approved these changes

@VishalNehra VishalNehra VishalNehra approved these changes

@EmmanuelMess EmmanuelMess Awaiting requested review from EmmanuelMess

Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-UIUX Related to user interface/experience (e.g. dialogs, notifications). From-telegram Issue reported through telegram channel Issue-Bug Related unexpected behavior or something worth investigating.
Projects
None yet
Milestone
v3.9
Development

Successfully merging this pull request may close these issues.

Debug bug: ClassCastException on ColorPickerDialog#onCreateDialog
3 participants
@TranceLove @VishalNehra @VishnuSanal