Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Working Oxygen Bubble Distributor and Sealers #289

Merged
merged 17 commits into from
Jan 23, 2024

Conversation

supersimple33
Copy link
Collaborator

@supersimple33 supersimple33 commented Dec 17, 2023

I have made a number of changes so that players can now setup breathing apparatuses on the moon. Fixes #270 if that is still a problem.

  • I added Oxygen onto the bubble distributor class name for clarity
  • I removed the button from the sealer since that logic is not longer needed and it is covered by using the redstone controls
  • Corrected the OXYGEN_INPUT_SLOT please confirm the number I switched it to is the correct one that we are trying to use
  • Moved syncing logic of the bubble size into trySyncSize
  • Set the oxygen bubble so that it always requires 1 unit of oxygen to function (certain scales would allow it to function for small radiuses with no o2 in the machine)
  • Added logic to bubble distributor to clear oxygen if machine is disabled
  • Added clearSeal logic to o2 sealer

@supersimple33
Copy link
Collaborator Author

supersimple33 commented Jan 16, 2024

Could someone check that my fix in 7884482 is correct? It fixes a bug where a infinite loop is created when quitting the game.

@vos6434 vos6434 merged commit c6eef0e into TeamGalacticraft:main Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Game crashes when trying to use bubble distributor and decompressor
2 participants