Fallen Trunk #2321
Open
Fallen Trunk #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/generated/resources/.cache/103d9f3f36b01595f1aa5172191e60eff02e6924
… increase the minimal length of the trunk; fix bugs; Add a TerraformingPiece as a temporary solution for bug where mounds get cut by chunk borders
# Conflicts: # src/generated/resources/.cache/103d9f3f36b01595f1aa5172191e60eff02e6924
Tamaized
reviewed
Dec 29, 2024
src/main/java/twilightforest/world/components/structures/fallentrunk/FallenTrunkPiece.java
Outdated
Show resolved
Hide resolved
Tamaized
reviewed
Dec 29, 2024
src/main/java/twilightforest/world/components/structures/fallentrunk/Hole.java
Outdated
Show resolved
Hide resolved
Tamaized
reviewed
Dec 29, 2024
...n/java/twilightforest/world/components/structures/fallentrunk/TrunkUnderDensityFunction.java
Outdated
Show resolved
Hide resolved
Tamaized
reviewed
Dec 29, 2024
...n/java/twilightforest/world/components/structures/fallentrunk/TrunkUnderDensityFunction.java
Outdated
Show resolved
Hide resolved
|
Rest of the PR looks fine to me other than what I already commented on. |
Tamaized
approved these changes
Dec 30, 2024
|
@Drullkus I want your review on this before it gets merged. |
…to no-build/1.21.1-fallen-trunk
…c final field in FallenTrunkPiece
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fallen trunks in
VALID_HOLLOW_TREE_BIOMES.Small fallen trunk:
Medium fallen trunk:
Large fallen trunk:
The large one, has 50% chance to spawn 3 chests with a spawner inside it. Chests' loot table is
TREE_CACHEwithout magic tree saplings. Spawner spawnsSWARM_SPIDER.