Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Auth | Week 16 | Eliane #336

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Conversation

El1an3
Copy link

@El1an3 El1an3 commented May 25, 2024

Copy link
Contributor

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Eliane, you did a really good job, however the app needed more testing. The backend is working fine, in the frontend there's an issue when logging in. Once the user is registered should be logged in and redirected to /dashboard but that's not happening in the current implementation, there is a missing netlify.toml config file to deploy the routes, check the recording from week 9 to check again how to do it. Also the login functionality is broken, despite entering the right credentials the login fails. Please double check these two things to pass 👌

@El1an3
Copy link
Author

El1an3 commented May 29, 2024

I will look into it, I tested before I handed it in. It worked then and still works for me now, it's just very slow. But I'll have another look.

@El1an3
Copy link
Author

El1an3 commented May 30, 2024

I fixed a couple of things. The login works for me, both with my old test users as well with a newly created one. Can you have another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants