-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project-auth-ji-viktoria-maja #341
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Maja Schouenke <[email protected]>
Co-authored-by: Maja Schouenke <[email protected]> Co-authored-by: viktoria-olo <[email protected]>
Secondary
Co-authored-by: jyy009 <[email protected]>
Co-authored-by: jyy009 <[email protected]>
style session page
split up formData state management
add expressListEndpoints and update readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello girls, good job implementing the auth for your final project! The app works well and it meets the requirements. I recommend to validate the input values like postcode and city, and add some rules to password or username (at the moment you can input letters in the postcode, numbers for city, and psw and username be just 1 character). it could be done either in the BE, for example:
password: {
type: String,
required: true,
validate: {
validator: function(v) {
return v.length >= 8;
},
message: props => `Password should be at least 8 characters long!`
}
}
or in the FE. Other than that you're on a great track so keep it up! 💯
Netlify link
https://heroic-beignet-77e068.netlify.app
Render
https://project-auth-kh49.onrender.com/
Collaborators
[viktoria-olo, schouenkes]