Add explicit implementations of FromMeta
methods to SpannedValue
and Override
#326
+142
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
SpannedValue
andOverride
implement only the top-level methods. This means that, if the "low-level" methods likefrom_string
are called, instead of the mid- or -top level methods likefrom_value
orfrom_meta
, the default behavior (an error) will be used. This was leading to errors with this structure:When parsed from
#[foo(long="bar")]
, this returns an "unexpected type string", because these types end up callingSpannedValue::from_value
directly, causing the default behavior (an error) instead of forwarding toString::from_value
.Added some regression tests for this behavior.