Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing LW2 attempt to fix corpses dropped by MC-ed enemies #29

Open
GafrieGithub opened this issue Jul 15, 2023 · 3 comments

Comments

@GafrieGithub
Copy link

Here is the LW2 code which make enemies who are mind controlled at the end of full salvage missions to drop their corpses:

else if (EffectState.GetX2Effect().EffectName == class'X2Effect_MindControl'.default.EffectName && AwardWrecks)

However, it works poorly with mods like "[WOTC] Dude, Where's My Loot?" or formerly "[WOTC] Loot Mind Control]" in that LW2 fixes only the corpses. If you are not using other mod, then you are missing on certain loot, and if you are using other mod then you get your loot, but also double the amount of corpses. So no matter what you do currently the overall amount of stuff you get is incorrect.
The easiest solution would be just to comment this section out and to warn players to just use a mod specifically focused on solving this issue.

@copyrite
Copy link

This would now make more sense on the main repo, https://github.com/long-war-2/lwotc/issues. Would you like to recreate it there, or shall I?

@copyrite
Copy link

Actually, nevermind. One can transfer GH issues between forks. @Tedster59, since you have the rights to both, could you do it? Should be a "-> Transfer issue" in the bottom right.

@copyrite
Copy link

Copied to long-war-2, can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants