Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support lossless register and deregister #1242

Merged
merged 2 commits into from
Mar 12, 2024
Merged

feat: support lossless register and deregister #1242

merged 2 commits into from
Mar 12, 2024

Conversation

shedfreewu
Copy link
Collaborator

@shedfreewu shedfreewu commented Mar 11, 2024

fix #977

PR Type

Describe what this PR does for and how you did.

feat: support lossless register and deregister

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 71.61%. Comparing base (3f5eda5) to head (0ed9743).
Report is 1 commits behind head on hoxton.

Files Patch % Lines
.../cloud/plugin/lossless/LosslessRegistryAspect.java 82.60% 4 Missing ⚠️
...cloud/polaris/registry/PolarisServiceRegistry.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             hoxton    #1242      +/-   ##
============================================
+ Coverage     71.17%   71.61%   +0.44%     
- Complexity     1590     1638      +48     
============================================
  Files           273      280       +7     
  Lines          6289     6388      +99     
  Branches        774      780       +6     
============================================
+ Hits           4476     4575      +99     
- Misses         1417     1422       +5     
+ Partials        396      391       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SkyeBeFreeman
SkyeBeFreeman previously approved these changes Mar 12, 2024
andrewshan
andrewshan previously approved these changes Mar 12, 2024
@shedfreewu shedfreewu dismissed stale reviews from andrewshan and SkyeBeFreeman via 580a8bd March 12, 2024 08:34
@SkyeBeFreeman SkyeBeFreeman merged commit 261ebea into Tencent:hoxton Mar 12, 2024
9 checks passed
@SkyeBeFreeman SkyeBeFreeman added this to the 1.14.0 milestone Mar 14, 2024
@SkyeBeFreeman SkyeBeFreeman linked an issue Mar 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

预计何时能够支持服务无损上下线?
4 participants