feat(bcs-bscp): feedserver support sync download file api #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlkaidChan
changed the title
AlkaidChan
force-pushed
the
feat/p2p-sync-download
branch
from
9c118b1
to
435c36d
Compare
AlkaidChan
changed the title
ifooth
reviewed
Apr 23, 2024
| @@ -130,3 +133,20 @@ func (c *client) BatchUpsertClientMetrics(kt *kit.Kit, clientData []*pbclient.Cl | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| func (c *client) GetAsyncDownloadTask(kt *kit.Kit, bizID uint32, taskID string) (string, error) { | |||
| @@ -202,6 +208,8 @@ func (fs *feedServer) finalizer() { | |||
| return | |||
| } | |||
|
|
|||
| fs.cleaner.Stop() | |||
| return r, nil | ||
| } | ||
|
|
||
| func (s *Service) getAsyncDownloadClientInfo(ctx context.Context, req *pbfs.AsyncDownloadReq) ( |
There was a problem hiding this comment.
Id / ID 不好混用，看看以前是用那个，保持统一下, BKAgentId
There was a problem hiding this comment.
这里应该是没有混用，所有我们自己定义的都是 XxxID，XxxId 这种是 proto 生成的
| k8s.io/klog/v2 v2.110.1 | ||
| ) | ||
|
|
||
| require ( |
| "download_speed": 0, | ||
| "tasks": []map[string]interface{}{ | ||
| { | ||
| "source": map[string]interface{}{ |
There was a problem hiding this comment.
感觉这里可以用struct封装下, source, target是一个， agent是一个
|
|
||
| func (s *Service) checkAndDownloadFile(kit *kit.Kit, filePath, signature string) error { | ||
| // block until file download | ||
| s.fileLock.Lock(filePath) |
There was a problem hiding this comment.
只对文件路径加锁，不同业务，app文件路径一样，内容不一样，加锁是不是不符合预期？
There was a problem hiding this comment.
这里的文件路径是这样的：
/data/gse/source/files/{bizID}/{sha256}
ifooth
approved these changes
Apr 24, 2024
wenxinlee2015
added a commit
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.