feat: project-manager支持原生ns接口 #3612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LidolLxf
force-pushed
the
feat_project_ns
branch
from
f2fdc14 to
84d876e
Compare
adevjoe
approved these changes
Dec 2, 2024
LidolLxf
force-pushed
the
feat_project_ns
branch
from
84d876e to
b7d776d
Compare
adevjoe
suggested changes
Dec 4, 2024
| return errorx.NewClusterErr(err.Error()) | ||
| } | ||
|
|
||
| if req.GetProjectIDOrCode() != "-" { |
| if err := json.Unmarshal(ns.Object.Raw, &pom); err != nil { | ||
| return namespaceList, err | ||
| } | ||
| if shared && pom.Annotations != nil && pom.Annotations[constant.AnnotationKeyProjectCode] != projectCode { |
There was a problem hiding this comment.
这里应该是
if !shared {
continue
}
if pom.Annotations == nil {
continue
}
if pom.Annotations[constant.AnnotationKeyProjectCode] != projectCode {
continue
}
adevjoe
suggested changes
Dec 4, 2024
| if err != nil { | ||
| return errorx.NewInnerErr(err.Error()) | ||
| } | ||
| mt, err = nsutils.FilterTableNamespaces(mt, true, project.ProjectCode) |
LidolLxf
force-pushed
the
feat_project_ns
branch
from
47dea7c to
63eda50
Compare
ifooth
approved these changes
Dec 5, 2024
evanlixin
added a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: project-manager支持原生ns接口