-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lower python version to 3.9 #7
Conversation
Reviewer's Guide by SourceryThis pull request lowers the minimum supported Python version to 3.9. This change is implemented by modifying the pyproject.toml file to allow Python 3.9 and updating the CI workflow to test against Python 3.9, 3.10, 3.11, and 3.12. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Tohrusky - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you explain the motivation for adding Python 3.9 support? Given its approaching end-of-life in 2025, it might increase maintenance burden without significant benefit unless there's a specific compatibility requirement.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Expand Python support to versions 3.9, 3.11, and 3.12.
Enhancements:
CI: