Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: ReportSys test for SLES pallet patch #825

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

FEATURE: ReportSys test for SLES pallet patch #825

wants to merge 4 commits into from

Conversation

megkido
Copy link

@megkido megkido commented Aug 24, 2020 •
edited
Loading

Output

frontend-0-0:/opt/stack/lib/python3.8/site-packages/stack/commands/report/system/tests # stack report system
====================================== test session starts ======================================
platform linux -- Python 3.8.3, pytest-6.0.1, py-1.9.0, pluggy-0.13.1 -- /opt/stack/bin/python3
cachedir: .pytest_cache
rootdir: /opt/stack/lib/python3.8/site-packages/stack/commands/report/system
plugins: testinfra-1.16.0
collected 35 items

tests/test_stacki.py::test_stack_list[local-box] PASSED
tests/test_stacki.py::test_stack_list[local-pallet] PASSED
tests/test_stacki.py::test_stack_list[local-cart] PASSED
tests/test_stacki.py::test_stack_list[local-network] PASSED
tests/test_stacki.py::test_stack_list[local-host] PASSED
tests/test_stacki.py::test_stack_list[local-host interface] PASSED
tests/test_stacki.py::test_stacki_pallets_sane[local] PASSED
tests/test_stacki.py::test_stacki_central_server[local] PASSED
tests/test_stacki.py::test_stacki_ca_correct[local] PASSED
tests/test_services.py::test_service_enabled_and_running[local-dhcpd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-named] SKIPPED
tests/test_services.py::test_service_enabled_and_running[local-rsyslog] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-processor] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-producer] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-publisher] PASSED
tests/test_services.py::test_service_enabled_and_running[local-sshd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-chronyd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-apache2] PASSED
tests/test_services.py::test_service_enabled_and_running[local-mysql] PASSED
tests/test_services.py::test_tftpd_enabled_and_running[local] PASSED
tests/test_services.py::test_logrotate_service_enabled[local] PASSED
tests/test_services.py::test_logrotate_configuration_valid[local] PASSED
tests/test_services.py::test_stacki_logrotate_file_exists[local] PASSED
tests/test_restapi.py::test_restapi_list_host PASSED
tests/test_backend_installs.py::TestBackendInstalls::test_backend[backend-0-0] PASSED
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0] SKIPPED
tests/test_backend_link.py::TestLinkUp::test_link_status[paramiko://backend-0-0] PASSED
tests/test_other_dhcp.py::test_other_dhcp_server[eth1] PASSED
tests/test_networks.py::test_hosts_in_correct_networks PASSED
tests/test_df.py::test_slash_not_full[local] PASSED
tests/test_df.py::test_export_not_full[local] PASSED
tests/test_df.py::test_var_not_full[local] PASSED
tests/test_sles_patch.py::test_sles_pallet_patched[local] PASSED
tests/test_pkgs.py::test_rpms_are_clean[local] PASSED
tests/test_pkgs.py::test_no_duplicate_rpms[local] PASSED

======================================= warnings summary ========================================
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0]
  /opt/stack/lib/python3.8/site-packages/paramiko/client.py:835: UserWarning: Unknown ssh-ed25519 host key for backend-0-0: b'f6d43303ee51d55add2c3ac4b0f8fac3'
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/warnings.html

========================================= Cluster Data ==========================================

------------------------------------------- list box --------------------------------------------

NAME     OS   PALLETS                                                       CARTS   REPOS
11sp3    sles SLES-11sp3-sles11 stacki-5.6.1-sles11                         ------- -----
12sp3    sles stacki-5.6.1-sles12 SLES-12sp3-sles12 stacki-5.6rc5-sles12    ------- -----
15sp1    sles SLES-15sp1-sles15 Packages-1-15sp1-sles15 stacki-5.6.1-sles15 ------- -----
default  sles stacki-5.6.1-sles12 SLES-12sp3-sles12                         vagrant -----
frontend sles stacki-5.6.1-sles12 SLES-12sp3-sles12                         ------- -----

------------------------------------------ list pallet ------------------------------------------

NAME       VERSION RELEASE ARCH   OS   BOXES
stacki     5.6.1   sles12  x86_64 sles default frontend 12sp3
SLES       12sp3   sles12  x86_64 sles default frontend 12sp3
SLES       15sp1   sles15  x86_64 sles 15sp1
Packages-1 15sp1   sles15  x86_64 sles 15sp1
SLES       11sp3   sles11  x86_64 sles 11sp3
stacki     5.6.1   sles15  x86_64 sles 15sp1
stacki     5.6.1   sles11  x86_64 sles 11sp3
stacki     5.6rc5  sles12  x86_64 sles 12sp3

------------------------------------------- list cart -------------------------------------------

NAME    BOXES
vagrant default

----------------------------------------- list network ------------------------------------------

NETWORK ADDRESS     MASK          GATEWAY       MTU ZONE DNS   PXE
private 192.168.0.0 255.255.255.0 192.168.121.1 --- ---- False True

------------------------------------------- list host -------------------------------------------

HOST         RACK RANK APPLIANCE OS   BOX      ENVIRONMENT OSACTION INSTALLACTION COMMENT
frontend-0-0 0    0    frontend  sles frontend ----------- default  default       -------
backend-0-0  0    0    backend   sles default  ----------- default  default       -------

-------------------------------------- list host interface --------------------------------------

HOST         INTERFACE DEFAULT NETWORK MAC               IP          NAME         MODULE VLAN OPTIONS CHANNEL
frontend-0-0 eth1      True    private 52:54:00:e3:a0:a8 192.168.0.2 frontend-0-0 ------ ---- ------- -------
backend-0-0  eth0      ------- ------- 52:54:00:75:5c:ff ----------- ------------ ------ ---- ------- -------
backend-0-0  eth1      True    private 52:54:00:00:00:03 192.168.0.1 backend-0-0  ------ ---- ------- -------

----------------------------------- SLES pallet patch source ------------------------------------

stacki-5.6rc5-sles12-sles-x86_64
----------------------------------- SLES pallet patch source ------------------------------------

stacki-5.6.1-sles15-sles-x86_64
==================================== short test summary info ====================================
SKIPPED [1] tests/test_services.py:38: named should only be running if a network is set to dns=true
SKIPPED [1] tests/test_partitions.py:37: Using default stacki partition config for host backend-0-0
=========================== 33 passed, 2 skipped, 1 warning in 12.02s ===========================

@megkido megkido requested a review from bsanders August 24, 2020 22:54
bsanders
bsanders suggested changes Aug 25, 2020
View reviewed changes
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
@megkido megkido force-pushed the feature/test_sles_patches branch from 8d88199 to 76c8041 Compare September 1, 2020 19:31
@megkido megkido force-pushed the feature/test_sles_patches branch 2 times, most recently from 9d66b6e to 6c8fea4 Compare September 2, 2020 03:57
@megkido megkido requested a review from caladd September 16, 2020 00:01
caladd
caladd suggested changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@caladd caladd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the recommended code changes and re-examine the code logic. I'm not sure this is actually testing that all the files in all the RPMs have the correct hashes.

common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
assert sles_flavors

# Find out where is stack-sles*images*.rpm file(s)
result = host.run('find /export/stack/pallets/stacki/ -name "*stack-sles-*.rpm"')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern should have a \ before the .:

"*stack-sles-*\.rpm"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having \ before . broke the code.

common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Show resolved Hide resolved
common/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated Show resolved Hide resolved
@megkido
Copy link
Author

megkido commented Oct 6, 2020 •
edited
Loading

Updated output

Failure case

--------------------------------- SLES12sp3 pallet patch source NOT found ----------------------------------

/opt/stack/pallet-patches/SLES-12sp3-sles12-sles-x86_64/add-stacki-squashfs/content

-------------------------------------- SLES15sp1 pallet patch source ---------------------------------------

stacki-5.6.1-sles15-sles-x86_64

-------------------------------------- SLES11sp3 pallet patch source ---------------------------------------

stacki-5.6rc5-sles12-sles-x86_64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsanders bsanders bsanders requested changes

@caladd caladd caladd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@megkido @caladd @bsanders