Make 0-length gravity lines invisible again #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NyakoFox
force-pushed
the
invisible-gravlines
branch
from
5d6fbb6 to
c7d3897
Compare
|
Should this be backported to 2.4 then? Change lgtm otherwise - if we can find the breaking commit that will help too. |
|
It's relatively minor so I'm not sure if it should be backported or not. I wouldn't be surprised if the breaking commit was 5de448b since that commit changes gravity lines from using thin rectangles to drawing actual lines. |
|
Makes sense to me - I need to update SDL for 2.4 anyway, so let's get this in! Will merge and cherry pick next time I'm at my desk. |
flibitijibibo
approved these changes
Nov 16, 2024
|
Also applied to 2.4-updates 25dd9d5 |
|
@flibitijibibo just checking - the version number will also be bumped to 2.4.3, right? |
|
Yep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
0-length gravity lines used to be invisible, but it "broke" some time in 2.4. This PR makes them invisible again.
Legal Stuff:
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement